From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753257AbdHGL4T (ORCPT ); Mon, 7 Aug 2017 07:56:19 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:33625 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753127AbdHGL4S (ORCPT ); Mon, 7 Aug 2017 07:56:18 -0400 From: Jonathan Liu To: Thierry Reding , David Airlie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jonathan Liu Subject: [PATCH] drm/panel: simple: Add missing panel_simple_unprepare calls Date: Mon, 7 Aug 2017 21:55:45 +1000 Message-Id: <20170807115545.27747-1-net147@gmail.com> X-Mailer: git-send-email 2.13.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org During panel removal or system shutdown panel_simple_disable is called which disables the panel backlight but the panel is still powered due to missing calls to panel_simple_unprepare. Fixes: d02fd93e2cd8 ("drm/panel: simple - Disable panel on shutdown") Cc: stable@vger.kernel.org # v3.16+ Signed-off-by: Jonathan Liu --- drivers/gpu/drm/panel/panel-simple.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 474fa759e06e..234af81fb3d0 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -369,6 +369,7 @@ static int panel_simple_remove(struct device *dev) drm_panel_remove(&panel->base); panel_simple_disable(&panel->base); + panel_simple_unprepare(&panel->base); if (panel->ddc) put_device(&panel->ddc->dev); @@ -384,6 +385,7 @@ static void panel_simple_shutdown(struct device *dev) struct panel_simple *panel = dev_get_drvdata(dev); panel_simple_disable(&panel->base); + panel_simple_unprepare(&panel->base); } static const struct drm_display_mode ampire_am_480272h3tmqw_t01h_mode = { -- 2.13.2