From: Johannes Thumshirn <jthumshirn@suse.de>
To: Anton Volkov <avolkov@ispras.ru>
Cc: tom.leiming@gmail.com, axboe@fb.com, osandov@fb.com,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
ldv-project@linuxtesting.org, khoroshilov@ispras.ru
Subject: Re: [PATCH] loop: fix to a race condition due to the early registration of device
Date: Mon, 7 Aug 2017 15:24:58 +0200 [thread overview]
Message-ID: <20170807132458.GA3978@linux-x5ow.site> (raw)
In-Reply-To: <e99d4f73-5d73-8141-558f-c918245abc42@ispras.ru>
On Mon, Aug 07, 2017 at 04:09:12PM +0300, Anton Volkov wrote:
> This is more of a style-oriented suggestion. This kind of template is
> commonly used in other modules.
Yes but there is no point in using gotos here (i.e. cleanup to be done), you
an just return directly.
And yes it is a minor nit.
Anyways,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-08-07 13:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 15:55 Possible race in loop.ko Anton Volkov
2017-08-01 12:39 ` Ming Lei
2017-08-03 15:01 ` [PATCH] loop: fix to a race condition due to the early registration of device Anton Volkov
2017-08-07 2:39 ` Ming Lei
2017-08-07 12:37 ` Anton Volkov
2017-08-07 12:54 ` Johannes Thumshirn
2017-08-07 13:09 ` Anton Volkov
2017-08-07 13:24 ` Johannes Thumshirn [this message]
2017-08-08 22:00 ` Omar Sandoval
2017-08-10 15:46 ` Anton Volkov
2017-08-15 18:51 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170807132458.GA3978@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=avolkov@ispras.ru \
--cc=axboe@fb.com \
--cc=khoroshilov@ispras.ru \
--cc=ldv-project@linuxtesting.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@fb.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox