From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751967AbdHGPsz (ORCPT <rfc822;w@1wt.eu>);
        Mon, 7 Aug 2017 11:48:55 -0400
Received: from mga09.intel.com ([134.134.136.24]:18762 "EHLO mga09.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751457AbdHGPsy (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 7 Aug 2017 11:48:54 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.41,338,1498546800"; 
   d="scan'208";a="1179890948"
Date: Mon, 7 Aug 2017 08:48:50 -0700
From: Andi Kleen <ak@linux.intel.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>, x86@kernel.org,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Dave Hansen <dave.hansen@intel.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Michal Hocko <mhocko@kernel.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 07/13] x86/mm: Make PGDIR_SHIFT and PTRS_PER_P4D
 variable
Message-ID: <20170807154850.GF3946@tassilo.jf.intel.com>
References: <20170807141451.80934-1-kirill.shutemov@linux.intel.com>
 <20170807141451.80934-8-kirill.shutemov@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170807141451.80934-8-kirill.shutemov@linux.intel.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +#ifdef CONFIG_X86_5LEVEL
> +unsigned int pgdir_shift = 48;
> +unsigned int ptrs_per_p4d = 512;

should be both __read_mostly

> +#ifdef CONFIG_X86_5LEVEL
> +unsigned int pgdir_shift = 48;
> +EXPORT_SYMBOL(pgdir_shift);
> +unsigned int ptrs_per_p4d = 512;
> +EXPORT_SYMBOL(ptrs_per_p4d);
> +#endif

Same.

-Andi