From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751940AbdHGQ33 (ORCPT ); Mon, 7 Aug 2017 12:29:29 -0400 Received: from mail-qk0-f172.google.com ([209.85.220.172]:35458 "EHLO mail-qk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751443AbdHGQ3Z (ORCPT ); Mon, 7 Aug 2017 12:29:25 -0400 Date: Mon, 7 Aug 2017 09:29:21 -0700 From: Tejun Heo To: Bhumika Goyal Cc: Julia Lawall , b.zolnierkie@samsung.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ata: make ata_port_operations const Message-ID: <20170807162920.GA537256@devbig577.frc2.facebook.com> References: <1502101922-13313-1-git-send-email-bhumirks@gmail.com> <20170807150727.GD4050379@devbig577.frc2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Mon, Aug 07, 2017 at 08:54:21PM +0530, Bhumika Goyal wrote: > I compiled the .o files and checked the size before and after > compilation. After making the structure const, bytes should move from > data to text segment of the memory and this is what happened. So, this > is how I tested it. Ah, I see, so the port_operations is never used directly. I'm not sure whether it'd be a good idea to selectively pick these and makr them const. Let's just leave them be. Thanks. -- tejun