public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] constify input usb_device_id.
Date: Mon, 7 Aug 2017 20:05:08 -0700	[thread overview]
Message-ID: <20170808030508.GD12328@dtor-ws> (raw)
In-Reply-To: <1502005287-17705-1-git-send-email-arvind.yadav.cs@gmail.com>

On Sun, Aug 06, 2017 at 01:11:19PM +0530, Arvind Yadav wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
> 
> Fix checkpatch.pl error in patch 1,3 and 7:
> ERROR: space prohibited before open square bracket '['.
> 
> Arvind Yadav (8):
>   [PATCH 1/8] Input: iforce: constify usb_device_id and fix space before '[' error.
>   [PATCH 2/8] Input: xpad: constify usb_device_id.
>   [PATCH 3/8] Input: keyspan_remote: constify usb_device_id.
>   [PATCH 4/8] Input: powermate: constify usb_device_id and fix space before '[' error.
>   [PATCH 5/8] Input: appletouch: constify usb_device_id.
>   [PATCH 6/8] Input: synaptics_usb: constify usb_device_id.
>   [PATCH 7/8] Input: acecad: constify usb_device_id and fix space before '[' error.
>   [PATCH 8/8] Input: kbtab: constify usb_device_id.
> 
>  drivers/input/joystick/iforce/iforce-usb.c | 2 +-
>  drivers/input/joystick/xpad.c              | 2 +-
>  drivers/input/misc/keyspan_remote.c        | 2 +-
>  drivers/input/misc/powermate.c             | 2 +-
>  drivers/input/mouse/appletouch.c           | 2 +-
>  drivers/input/mouse/synaptics_usb.c        | 2 +-
>  drivers/input/tablet/acecad.c              | 2 +-
>  drivers/input/tablet/kbtab.c               | 2 +-
>  8 files changed, 8 insertions(+), 8 deletions(-)

Applied the lot, thank you.

-- 
Dmitry

      parent reply	other threads:[~2017-08-08  3:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-06  7:41 [PATCH 0/8] constify input usb_device_id Arvind Yadav
2017-08-06  7:41 ` [PATCH 1/8] Input: iforce: constify usb_device_id and fix space before '[' error: Arvind Yadav
2017-08-06  7:41 ` [PATCH 2/8] Input: xpad: constify usb_device_id Arvind Yadav
2017-08-06  7:41 ` [PATCH 3/8] Input: keyspan_remote: " Arvind Yadav
2017-08-06  7:41 ` [PATCH 4/8] Input: powermate: constify usb_device_id and fix space before '[' error Arvind Yadav
2017-08-06  7:41 ` [PATCH 5/8] Input: appletouch: constify usb_device_id Arvind Yadav
2017-08-06  7:41 ` [PATCH 6/8] Input: synaptics_usb: " Arvind Yadav
2017-08-06  7:41 ` [PATCH 7/8] Input: acecad: constify usb_device_idi and fix space before '[' error Arvind Yadav
2017-08-06  7:41 ` [PATCH 8/8] Input: kbtab: constify usb_device_id Arvind Yadav
2017-08-08  3:05 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170808030508.GD12328@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox