* Re: [PATCH] staging: pi433: style fix - space after asterisk
2017-08-08 13:54 [PATCH] staging: pi433: style fix - space after asterisk Marcin Ciupak
@ 2017-08-08 12:13 ` Marcus Wolf
0 siblings, 0 replies; 2+ messages in thread
From: Marcus Wolf @ 2017-08-08 12:13 UTC (permalink / raw)
To: Greg Kroah-Hartman, Marcin Ciupak; +Cc: linux-kernel, devel
Reviewed-by: Marcus Wolf <linux@wolf-entwicklungen.de>
Thank you Marcin!
> Marcin Ciupak <marcin.s.ciupak@gmail.com> hat am 8. August 2017 um 15:54
> geschrieben:
>
>
> This patch is intended to fix coding style issues in order to comply
> with kernel coding style guide as requested by TODO file.
>
> It fixes the following checkpatch.pl error:
>
> ERROR: "foo * bar" should be "foo *bar"
>
> Note:
> "WARNING: line over 80 characters" remains valid here and could be fixed
> by another patch.
>
> Signed-off-by: Marcin Ciupak <marcin.s.ciupak@gmail.com>
> ---
> drivers/staging/pi433/rf69.c | 2 +-
> drivers/staging/pi433/rf69.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
> index f83523e3395d..9f4e7173c688 100644
> --- a/drivers/staging/pi433/rf69.c
> +++ b/drivers/staging/pi433/rf69.c
> @@ -740,7 +740,7 @@ int rf69_set_sync_values(struct spi_device *spi, u8
> syncValues[8])
> return retval;
> }
>
> -int rf69_set_packet_format(struct spi_device * spi, enum packetFormat
> packetFormat)
> +int rf69_set_packet_format(struct spi_device *spi, enum packetFormat
> packetFormat)
> {
> #ifdef DEBUG
> dev_dbg(&spi->dev, "set: packet format");
> diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h
> index b81e0762032e..fbccaae51c61 100644
> --- a/drivers/staging/pi433/rf69.h
> +++ b/drivers/staging/pi433/rf69.h
> @@ -61,7 +61,7 @@ int rf69_set_fifo_fill_condition(struct spi_device *spi,
> enum fifoFillCondition
> int rf69_set_sync_size(struct spi_device *spi, u8 sync_size);
> int rf69_set_sync_tolerance(struct spi_device *spi, u8 syncTolerance);
> int rf69_set_sync_values(struct spi_device *spi, u8 syncValues[8]);
> -int rf69_set_packet_format(struct spi_device * spi, enum packetFormat
> packetFormat);
> +int rf69_set_packet_format(struct spi_device *spi, enum packetFormat
> packetFormat);
> int rf69_set_crc_enable(struct spi_device *spi, enum optionOnOff optionOnOff);
> int rf69_set_adressFiltering(struct spi_device *spi, enum addressFiltering
> addressFiltering);
> int rf69_set_payload_length(struct spi_device *spi, u8 payloadLength);
> --
> 2.13.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] staging: pi433: style fix - space after asterisk
@ 2017-08-08 13:54 Marcin Ciupak
2017-08-08 12:13 ` Marcus Wolf
0 siblings, 1 reply; 2+ messages in thread
From: Marcin Ciupak @ 2017-08-08 13:54 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Marcus Wolf, devel, linux-kernel
This patch is intended to fix coding style issues in order to comply
with kernel coding style guide as requested by TODO file.
It fixes the following checkpatch.pl error:
ERROR: "foo * bar" should be "foo *bar"
Note:
"WARNING: line over 80 characters" remains valid here and could be fixed
by another patch.
Signed-off-by: Marcin Ciupak <marcin.s.ciupak@gmail.com>
---
drivers/staging/pi433/rf69.c | 2 +-
drivers/staging/pi433/rf69.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index f83523e3395d..9f4e7173c688 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -740,7 +740,7 @@ int rf69_set_sync_values(struct spi_device *spi, u8 syncValues[8])
return retval;
}
-int rf69_set_packet_format(struct spi_device * spi, enum packetFormat packetFormat)
+int rf69_set_packet_format(struct spi_device *spi, enum packetFormat packetFormat)
{
#ifdef DEBUG
dev_dbg(&spi->dev, "set: packet format");
diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h
index b81e0762032e..fbccaae51c61 100644
--- a/drivers/staging/pi433/rf69.h
+++ b/drivers/staging/pi433/rf69.h
@@ -61,7 +61,7 @@ int rf69_set_fifo_fill_condition(struct spi_device *spi, enum fifoFillCondition
int rf69_set_sync_size(struct spi_device *spi, u8 sync_size);
int rf69_set_sync_tolerance(struct spi_device *spi, u8 syncTolerance);
int rf69_set_sync_values(struct spi_device *spi, u8 syncValues[8]);
-int rf69_set_packet_format(struct spi_device * spi, enum packetFormat packetFormat);
+int rf69_set_packet_format(struct spi_device *spi, enum packetFormat packetFormat);
int rf69_set_crc_enable(struct spi_device *spi, enum optionOnOff optionOnOff);
int rf69_set_adressFiltering(struct spi_device *spi, enum addressFiltering addressFiltering);
int rf69_set_payload_length(struct spi_device *spi, u8 payloadLength);
--
2.13.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-08 12:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-08 13:54 [PATCH] staging: pi433: style fix - space after asterisk Marcin Ciupak
2017-08-08 12:13 ` Marcus Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox