From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752348AbdHHQ3E (ORCPT ); Tue, 8 Aug 2017 12:29:04 -0400 Received: from mout.gmx.net ([212.227.17.22]:52394 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752082AbdHHQ3C (ORCPT ); Tue, 8 Aug 2017 12:29:02 -0400 Date: Tue, 8 Aug 2017 18:28:41 +0200 From: Helge Deller To: "Theodore Ts'o" , "Jason A. Donenfeld" , linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, torvalds@linux-foundation.org, kernel-hardening@lists.openwall.com, linux-ia64@vger.kernel.org Subject: [PATCH] random: fix warning message on ia64 and parisc Message-ID: <20170808162841.GA8668@p100.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-Provags-ID: V03:K0:qvPPh4xEmSuFVqo0bT1yMsP25NhvgFsPjX2wmQk4j9I7SAYjXs8 n0watiUKLJ0OKx7xUQLXKRj67yXhfvZVJ/TbGii7D/rcsoYUJVUEkkBUSM44sXb0gzxNKfU Qh2A2EsNKfhKVs0ZAjq35SsLUTdNM56WA/fsIeIbJbncVnZ4QtBhtlexHbFDfwNpTOSHCiL gtJQhffCIUvix9s90idwQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:DBPqyybe3Wc=:DQ5en6jHe20wLYIWuVNg9t 14Km86Xnc5cCwtuuJTOIIJVKlYyeY00xP1y6R3BVjGGTwD/kDT3NtftaqA86UJ4Nfamekm9Jh hJDASWrubWC2+8u6p1Xdt+6n6X/oc2o5zt/ZAFobw/5+1QK9qYTWZTRLVEKZl5zgONen+bn61 OC8KlO+kD6f1AEBpxdwceDLY/HOJjGEkj/493sSbLCrSjTbyODzq/2YaCjSBMFMUl3DVrzQJN kqvxFpC4x814NPj483M2/KNOGagfypsNj93Y8aYGsBu5gK50KMbOF+YWwGGqt5vxlc8FSvhFj uF84oRKNx9dEdaD6572LfjUj89eN+qZiOXGdSwBSZEYWhb1Brxaxk0FwtLfBxxyDhsrbumeyk MkFXxF+ZrpLPXvWClogVpLThFdkRyOE9Wq7QThioJTvW8J239E+cMFpX3pveaE/s4AbJiTBql 2gMu2dSpg95OMHKFsXdtHp7nqrpvLdp9/2+87gAAqIpfM7Ymt+rvlwcFLLEf51YFeaJch4gUv sgHJ4qgzEugI3MRhyHnLT+e9PbX0KIb4FY1YoLp8n9PizT7dnLI3CsTPa1lzctEaE9x1ktHYb WxumP6PLfM3s/AgqqlIWj9N9fk4nMeyGNj+etdNV3QLDwneB9okPEBaIKdBkh0zagGQd/In5P 7n7K2aE4ok+1a+ICgS5LDMuKIh4qeLKEgIq3KCISQvdrK3yU9qgO9oAvVnW8N0gnF2mlRjOkx Mu7/1yE1a7bffNmqVFyKLHG5iuX1JH4ZhmYTUW/LOrxFXBxyz1eo2kfDF6fg+ALskfmGv/tUa pbS8mnQK9ieZNVuUPnxs3VW2JcdYA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the warning message on the parisc and IA64 architectures to show the correct function name of the caller by using %pS instead of %pF. The message is printed with the value of _RET_IP_ which calls __builtin_return_address(0) and as such returns the IP address caller instead of pointer to a function descriptor of the caller. The effect of this patch is visible on the parisc and ia64 architectures only since those are the ones which use function descriptors while on all others %pS and %pF will behave the same. Cc: Theodore Ts'o Cc: Jason A. Donenfeld Signed-off-by: Helge Deller Fixes: eecabf567422 ("random: suppress spammy warnings about unseeded randomness") Fixes: d06bfd1989fe ("random: warn when kernel uses unseeded randomness") diff --git a/drivers/char/random.c b/drivers/char/random.c index afa3ce7..8ad9270 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -1492,7 +1492,7 @@ static void _warn_unseeded_randomness(const char *func_name, void *caller, #ifndef CONFIG_WARN_ALL_UNSEEDED_RANDOM print_once = true; #endif - pr_notice("random: %s called from %pF with crng_init=%d\n", + pr_notice("random: %s called from %pS with crng_init=%d\n", func_name, caller, crng_init); }