public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>, Davidlohr Bueso <dbueso@suse.de>,
	Thomas Gleixner <tglx@linutronix.de>, Chris Mason <clm@fb.com>,
	Darren Hart <dvhart@linux.intel.com>,
	Hugh Dickins <hughd@google.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Davidlohr Bueso <dave@stgolabs.net>
Subject: Re: kernel BUG at kernel/futex.c:679 on v4.13-rc3-ish on arm64
Date: Tue, 8 Aug 2017 17:59:31 +0100	[thread overview]
Message-ID: <20170808165930.GI19207@leverpostej> (raw)
In-Reply-To: <20170808164422.pp4uajinxl5stvhg@suse.de>

On Tue, Aug 08, 2017 at 05:44:22PM +0100, Mel Gorman wrote:
> On Tue, Aug 08, 2017 at 09:06:48AM -0700, Linus Torvalds wrote:
> > On Tue, Aug 8, 2017 at 8:41 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> > >
> > > With my __BUG_FLAGS() issue corrected, the WARN_ON_ONCE() fires once,
> > > and everything else seems fine. I'll have a go with additional debug
> > > enabled just in case.
> > 
> > Ok, great, a - mostly - false alarm.

Indeed; sorry for the somewhat bogus report.

> > I do wonder if we should just remove even that WARN_ON_ONCE() - I
> > think it was added to be careful, and the code seems to do the right
> > thing.

> If Mark confirms that removing the warning is ok for his test case, I'll
> send a patch to Thomas with a tag for stable and it should arrive at your
> inbox eventually. If I don't hear from Mark, I'll have time to try the
> test case in the morning and go from there.

So far my test case hasn't triggered any other noticeable issue, nor
splats from any debug option I have enabled, so removing the warning
sounds good to me.

I'll throw Syzkaller at a kernel with the warning removed. Given this is
the first time I've hit this after many days worth of fuzzing recent
kernels, I suspect it won't hit anything interesting by tomorrow
morning.

Thanks,
Mark.

      reply	other threads:[~2017-08-08 17:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-08 10:52 kernel BUG at kernel/futex.c:679 on v4.13-rc3-ish on arm64 Mark Rutland
2017-08-08 14:57 ` Mark Rutland
2017-08-08 15:14   ` Mark Rutland
2017-08-08 15:32 ` Mel Gorman
2017-08-08 15:41   ` Mark Rutland
2017-08-08 16:06     ` Linus Torvalds
2017-08-08 16:44       ` Mel Gorman
2017-08-08 16:59         ` Mark Rutland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170808165930.GI19207@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=bigeasy@linutronix.de \
    --cc=clm@fb.com \
    --cc=dave@stgolabs.net \
    --cc=dbueso@suse.de \
    --cc=dvhart@linux.intel.com \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox