From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752337AbdHHRAm (ORCPT <rfc822;w@1wt.eu>);
        Tue, 8 Aug 2017 13:00:42 -0400
Received: from foss.arm.com ([217.140.101.70]:38818 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752059AbdHHRAk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 8 Aug 2017 13:00:40 -0400
Date: Tue, 8 Aug 2017 17:59:31 +0100
From: Mark Rutland <mark.rutland@arm.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>, Davidlohr Bueso <dbueso@suse.de>,
        Thomas Gleixner <tglx@linutronix.de>, Chris Mason <clm@fb.com>,
        Darren Hart <dvhart@linux.intel.com>, Hugh Dickins <hughd@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Davidlohr Bueso <dave@stgolabs.net>
Subject: Re: kernel BUG at kernel/futex.c:679 on v4.13-rc3-ish on arm64
Message-ID: <20170808165930.GI19207@leverpostej>
References: <20170808105204.GB19207@leverpostej>
 <20170808153230.uvojxr2f3jwzxcpk@suse.de>
 <20170808154155.GG19207@leverpostej>
 <CA+55aFzHT3Ymwio8cwBcUehEM50XsDLRyVF8PFT8S7whsECNZQ@mail.gmail.com>
 <20170808164422.pp4uajinxl5stvhg@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170808164422.pp4uajinxl5stvhg@suse.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 08, 2017 at 05:44:22PM +0100, Mel Gorman wrote:
> On Tue, Aug 08, 2017 at 09:06:48AM -0700, Linus Torvalds wrote:
> > On Tue, Aug 8, 2017 at 8:41 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> > >
> > > With my __BUG_FLAGS() issue corrected, the WARN_ON_ONCE() fires once,
> > > and everything else seems fine. I'll have a go with additional debug
> > > enabled just in case.
> > 
> > Ok, great, a - mostly - false alarm.

Indeed; sorry for the somewhat bogus report.

> > I do wonder if we should just remove even that WARN_ON_ONCE() - I
> > think it was added to be careful, and the code seems to do the right
> > thing.

> If Mark confirms that removing the warning is ok for his test case, I'll
> send a patch to Thomas with a tag for stable and it should arrive at your
> inbox eventually. If I don't hear from Mark, I'll have time to try the
> test case in the morning and go from there.

So far my test case hasn't triggered any other noticeable issue, nor
splats from any debug option I have enabled, so removing the warning
sounds good to me.

I'll throw Syzkaller at a kernel with the warning removed. Given this is
the first time I've hit this after many days worth of fuzzing recent
kernels, I suspect it won't hit anything interesting by tomorrow
morning.

Thanks,
Mark.