public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: Anton Volkov <avolkov@ispras.ru>
Cc: tom.leiming@gmail.com, axboe@fb.com, osandov@fb.com,
	linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	ldv-project@linuxtesting.org, khoroshilov@ispras.ru
Subject: Re: [PATCH] loop: fix to a race condition due to the early registration of device
Date: Tue, 8 Aug 2017 15:00:47 -0700	[thread overview]
Message-ID: <20170808220047.GA4072@vader.DHCP.thefacebook.com> (raw)
In-Reply-To: <1502109470-2945-1-git-send-email-avolkov@ispras.ru>

On Mon, Aug 07, 2017 at 03:37:50PM +0300, Anton Volkov wrote:
> The early device registration made possible a race leading to allocations
> of disks with wrong minors.
> 
> This patch moves the device registration further down the loop_init
> function to make the race infeasible.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Anton Volkov <avolkov@ispras.ru>
> Reviewed-by: Ming Lei <ming.lei@redhat.com>

Hi, Anton,

Were you able to reproduce this issue or was it purely theoretical? If
the former, it'd be nice if you could add a test case to blktests [1].

1: https://github.com/osandov/blktests

Thanks!
Omar

  parent reply	other threads:[~2017-08-08 22:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-28 15:55 Possible race in loop.ko Anton Volkov
2017-08-01 12:39 ` Ming Lei
2017-08-03 15:01   ` [PATCH] loop: fix to a race condition due to the early registration of device Anton Volkov
2017-08-07  2:39     ` Ming Lei
2017-08-07 12:37       ` Anton Volkov
2017-08-07 12:54         ` Johannes Thumshirn
2017-08-07 13:09           ` Anton Volkov
2017-08-07 13:24             ` Johannes Thumshirn
2017-08-08 22:00         ` Omar Sandoval [this message]
2017-08-10 15:46           ` Anton Volkov
2017-08-15 18:51         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170808220047.GA4072@vader.DHCP.thefacebook.com \
    --to=osandov@osandov.com \
    --cc=avolkov@ispras.ru \
    --cc=axboe@fb.com \
    --cc=khoroshilov@ispras.ru \
    --cc=ldv-project@linuxtesting.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=osandov@fb.com \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox