From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752613AbdHIIoO (ORCPT ); Wed, 9 Aug 2017 04:44:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53200 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752454AbdHIIoN (ORCPT ); Wed, 9 Aug 2017 04:44:13 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7E5237EA92 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=javierm@redhat.com From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Hans de Goede , Javier Martinez Canillas , Lee Jones Subject: [PATCH 1/2] mfd: intel_soc_pmic_chtwc: Remove unneeded I2C device ID table Date: Wed, 9 Aug 2017 10:44:03 +0200 Message-Id: <20170809084404.781-1-javierm@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 09 Aug 2017 08:44:13 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver has an empty I2C device table as a workaround for a previous bug in the I2C core that was returning -ENODEV in i2c_device_probe() if the driver didn't have an I2C device ID table. Even when is for an ACPI only device and so the driver shouldn't need an I2C ID table in theory. But now this issue has been fixed by commit c64ffff7a9d1 ("i2c: core: Allow empty id_table in ACPI case as well"), so the empty I2C device ID table can be removed. Signed-off-by: Javier Martinez Canillas --- drivers/mfd/intel_soc_pmic_chtwc.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/mfd/intel_soc_pmic_chtwc.c b/drivers/mfd/intel_soc_pmic_chtwc.c index b35da01d5bcf..ca01ecd1e546 100644 --- a/drivers/mfd/intel_soc_pmic_chtwc.c +++ b/drivers/mfd/intel_soc_pmic_chtwc.c @@ -208,10 +208,6 @@ static int __maybe_unused cht_wc_resume(struct device *dev) } static SIMPLE_DEV_PM_OPS(cht_wc_pm_ops, cht_wc_suspend, cht_wc_resume); -static const struct i2c_device_id cht_wc_i2c_id[] = { - { } -}; - static const struct acpi_device_id cht_wc_acpi_ids[] = { { "INT34D3", }, { } @@ -225,6 +221,5 @@ static struct i2c_driver cht_wc_driver = { }, .probe_new = cht_wc_probe, .shutdown = cht_wc_shutdown, - .id_table = cht_wc_i2c_id, }; builtin_i2c_driver(cht_wc_driver); -- 2.13.3