From: Christian Gromm <christian.gromm@microchip.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: <gregkh@linuxfoundation.org>, <luca@lucaceresoli.net>,
<florian.c.schilhabel@googlemail.com>,
<devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] staging: most: usb: constify usb_device_id
Date: Wed, 9 Aug 2017 11:42:39 +0200 [thread overview]
Message-ID: <20170809114239.2ac9a210@xps13> (raw)
In-Reply-To: <1502212995-17482-2-git-send-email-arvind.yadav.cs@gmail.com>
On Tue, 8 Aug 2017 22:53:13 +0530
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Christian Gromm <christian.gromm@microchip.com>
> ---
> drivers/staging/most/hdm-usb/hdm_usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c
> b/drivers/staging/most/hdm-usb/hdm_usb.c index d0f68cb..a9c3785 100644
> --- a/drivers/staging/most/hdm-usb/hdm_usb.c
> +++ b/drivers/staging/most/hdm-usb/hdm_usb.c
> @@ -832,7 +832,7 @@ static const struct file_operations hdm_usb_fops
> = { /**
> * usb_device_id - ID table for HCD device probing
> */
> -static struct usb_device_id usbid[] = {
> +static const struct usb_device_id usbid[] = {
> { USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_BRDG), },
> { USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_OS81118), },
> { USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_OS81119), },
--
thanks,
Chris
Christian Gromm
Principal Software Engineer
Microchip Technology Germany II GmbH & Co. KG
Emmy-Noether-Straße 14
76131 Karlsruhe | Germany
Tel: +49 721 62537 466 | Fax: +49 721 62537 119
christian.gromm@microchip.com | www.microchip.com
Firmensitz: Ismaning
Registergericht: Amtsgericht München, HRA 98692
Persönlich haftende Gesellschafterin: Microchip Technology Germany GmbH
mit Sitz in Ismaning Registergericht: München, HRB 197 653
Geschäftsführer: Mohammed Nawaz Sharif, James Eric Bjornholt, Norbert
Siedhoff
Diese E-Mail kann vertrauliche Informationen enthalten. Sie darf nicht
durch andere als die ursprünglich genannten Adressaten genutzt, kopiert
oder weitergeleitet werden. This e-mail may contain confidential
information and should not be used, copied or disclosed by anyone who
is not the original intended recipient.
next prev parent reply other threads:[~2017-08-09 9:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 17:23 [PATCH 0/3] constify staging usb_device_id Arvind Yadav
2017-08-08 17:23 ` [PATCH 1/3] staging: most: usb: constify usb_device_id Arvind Yadav
2017-08-09 9:42 ` Christian Gromm [this message]
2017-08-08 17:23 ` [PATCH 2/3] staging: rtl8188eu: " Arvind Yadav
2017-08-08 17:23 ` [PATCH 3/3] staging: rtl8712: " Arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809114239.2ac9a210@xps13 \
--to=christian.gromm@microchip.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaceresoli.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).