Re: [PATCH v4 2/4] thermal: add brcmstb AVS TMON driver

Markus Mayer
2017-09-26T21:37:02Z

On 25 September 2017 at 23:17, Zhang, Rui <rui.zhang@intel.com> wrote:
> Hi, Florian,
>
>> -----Original Message-----
>> From: Florian Fainelli [mailto:f.fainelli@gmail.com]
>> Sent: Tuesday, September 26, 2017 12:14 PM
>> To: Zhang, Rui <rui.zhang@intel.com>; Rafal Milecki <rafal@milecki.pl>
>> Cc: Markus Mayer <code@mmayer.net>; Eduardo Valentin
>> <edubezval@gmail.com>; Rob Herring <robh+dt@kernel.org>; Mark Rutland
>> <mark.rutland@arm.com>; Doug Berger <opendmb@gmail.com>; Brian
>> Norris <computersforpeace@gmail.com>; Gregory Fong
>> <gregory.0xf0@gmail.com>; Russell King <linux@armlinux.org.uk>; Catalin
>> Marinas <catalin.marinas@arm.com>; Will Deacon <will.deacon@arm.com>;
>> Arnd Bergmann <arnd@arndb.de>; Olof Johansson <olof@lixom.net>;
>> Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>; Power
>> Management List <linux-pm@vger.kernel.org>; Device Tree List
>> <devicetree@vger.kernel.org>; ARM Kernel List <linux-arm-
>> kernel@lists.infradead.org>; Linux Kernel Mailing List <linux-
>> kernel@vger.kernel.org>; Markus Mayer <mmayer@broadcom.com>
>> Subject: Re: [PATCH v4 2/4] thermal: add brcmstb AVS TMON driver
>> Importance: High
>>
>> On 09/25/2017 08:02 PM, Zhang, Rui wrote:
>> > Hi, Florian,
>> >
>> > This patch set was dropped in the last minute because of this
>> > discussion https://patchwork.kernel.org/patch/9936325/
>> > as I don’t want to rebase the patch before sending the pull request.
>>
>> Ah, you wanted to squash that patch into the initial submission?
>>
>> >
>> > I don’t think we can make it for 4.14.
>> > Eduardo will be back and pick the soc patches for 4.15.
>>
>> I assume you would want to get that particular patch squashed into a clean
>> submission targeting 4.15 now, right?
>>
> Yes. As the patch in this thread has not been in upstream yet, I'd prefer the
> fix/cleanup meld into the original patch before sending upstream.

I sent out v5 a few minutes ago. See https://lkml.org/lkml/2017/9/26/746.

Regards,
-Markus

> Thanks,
> Rui
>
>> Thanks
>>
>> >
>> > Thanks,
>> > rui
>> >
>> >
>> >
>> > -----Original Message-----
>> > From: Florian Fainelli [mailto:f.fainelli@gmail.com]
>> > Sent: Monday, September 25, 2017 5:11 AM
>> > To: Zhang, Rui <rui.zhang@intel.com>; Rafał Miłecki <rafal@milecki.pl>
>> > Cc: Markus Mayer <code@mmayer.net>; Eduardo Valentin
>> > <edubezval@gmail.com>; Rob Herring <robh+dt@kernel.org>; Mark
>> Rutland
>> > <mark.rutland@arm.com>; Doug Berger <opendmb@gmail.com>; Brian
>> Norris
>> > <computersforpeace@gmail.com>; Gregory Fong
>> <gregory.0xf0@gmail.com>;
>> > Russell King <linux@armlinux.org.uk>; Catalin Marinas
>> > <catalin.marinas@arm.com>; Will Deacon <will.deacon@arm.com>; Arnd
>> > Bergmann <arnd@arndb.de>; Olof Johansson <olof@lixom.net>;
>> Broadcom
>> > Kernel List <bcm-kernel-feedback-list@broadcom.com>; Power
>> Management
>> > List <linux-pm@vger.kernel.org>; Device Tree List
>> > <devicetree@vger.kernel.org>; ARM Kernel List
>> > <linux-arm-kernel@lists.infradead.org>; Linux Kernel Mailing List
>> > <linux-kernel@vger.kernel.org>; Markus Mayer <mmayer@broadcom.com>
>> > Subject: Re: [PATCH v4 2/4] thermal: add brcmstb AVS TMON driver
>> > Importance: High
>> >
>> > Le 08/14/17 à 23:48, Zhang Rui a écrit :
>> >> On Tue, 2017-08-15 at 08:42 +0200, Rafał Miłecki wrote:
>> >>> On 2017-08-15 08:08, Zhang Rui wrote:
>> >>>>
>> >>>>>
>> >>>>> diff --git a/drivers/thermal/broadcom/Kconfig
>> >>>>> b/drivers/thermal/broadcom/Kconfig
>> >>>>> index 42c098e..c106a15 100644
>> >>>>> --- a/drivers/thermal/broadcom/Kconfig
>> >>>>> +++ b/drivers/thermal/broadcom/Kconfig
>> >>>>> @@ -6,6 +6,13 @@ config BCM2835_THERMAL
>> >>>>> help
>> >>>>> Support for thermal sensors on Broadcom bcm2835 SoCs.
>> >>>>>
>> >>>>> +config BRCMSTB_THERMAL
>> >>>>> + tristate "Broadcom STB AVS TMON thermal driver"
>> >>>>> + depends on ARCH_BRCMSTB || COMPILE_TEST
>> >>>>> + help
>> >>>>> + Enable this driver if you have a Broadcom STB SoC and
>> >>>>> would like
>> >>>>> + thermal framework support.
>> >>>>> +
>> >>>> I don't understand why I got the following checkpatch warning
>> >>>>
>> >>>> WARNING: please write a paragraph that describes the config symbol
>> >>>> fully
>> >>>> #73: FILE: drivers/thermal/broadcom/Kconfig:9:
>> >>>> +config BRCMSTB_THERMAL
>> >>>>
>> >>>> I didn't see this for other Kconfig changes.
>> >>> It's because your help message is only 2 lines long (instead of 3).
>> >>>
>> >>> Some (many?) maintainers aren't pedantic about that, a common sense
>> >>> should be applied ;)
>> >>
>> >> thanks for explaining.
>> >> Patch 1 and 2 queued for next merge window.
>> >
>> > Humm, I don't see this driver in your latest 4.14 pull request to Linus, so
>> what happened here exactly? Can we expect this driver to be submitted for
>> 4.14 or we just happened to have missed this window now?
>> > --
>> > Florian
>> >
>>
>> --
>> Florian