[PATCH 1/2] ARM: dts: am571x-idk: Fix GPIO polarity for MMC1 card detect

[PATCH 1/2] ARM: dts: am571x-idk: Fix GPIO polarity for MMC1 card detect

[Kishon Vijay Abraham I]

The GPIO polarity for MMC1 card detect is set to '0' which means
active-high. However the polarity should be active-low. Fix it
here.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 arch/arm/boot/dts/am571x-idk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/am571x-idk.dts b/arch/arm/boot/dts/am571x-idk.dts
index 7b207835b2d1..adc70fb091a2 100644
--- a/arch/arm/boot/dts/am571x-idk.dts
+++ b/arch/arm/boot/dts/am571x-idk.dts
@@ -68,7 +68,7 @@
 	status = "okay";
 	vmmc-supply = <&ldo1_reg>;
 	bus-width = <4>;
-	cd-gpios = <&gpio6 27 0>; /* gpio 219 */
+	cd-gpios = <&gpio6 27 GPIO_ACTIVE_LOW>; /* gpio 219 */
 };
 
 &omap_dwc3_2 {
-- 
2.11.0

[PATCH 2/2] ARM: dts: am572x-idk: Fix GPIO polarity for MMC1 card detect

[Kishon Vijay Abraham I]

The GPIO polarity for MMC1 card detect is set to '0' which means
active-high. However the polarity should be active-low. Fix it
here.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 arch/arm/boot/dts/am572x-idk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/am572x-idk.dts b/arch/arm/boot/dts/am572x-idk.dts
index 9da6d83ca185..940fcbe5380b 100644
--- a/arch/arm/boot/dts/am572x-idk.dts
+++ b/arch/arm/boot/dts/am572x-idk.dts
@@ -81,7 +81,7 @@
 	vmmc-supply = <&v3_3d>;
 	vmmc_aux-supply = <&ldo1_reg>;
 	bus-width = <4>;
-	cd-gpios = <&gpio6 27 0>; /* gpio 219 */
+	cd-gpios = <&gpio6 27 GPIO_ACTIVE_LOW>; /* gpio 219 */
 };
 
 &sn65hvs882 {
-- 
2.11.0

Re: [PATCH 1/2] ARM: dts: am571x-idk: Fix GPIO polarity for MMC1 card detect

[Tony Lindgren]

* Kishon Vijay Abraham I <kishon@ti.com> [170807 22:22]:
> The GPIO polarity for MMC1 card detect is set to '0' which means
> active-high. However the polarity should be active-low. Fix it
> here.

Can these wait for v4.14 merge window or do these fix known
issues?

Regards,

Tony

Re: [PATCH 1/2] ARM: dts: am571x-idk: Fix GPIO polarity for MMC1 card detect

[Kishon Vijay Abraham I]

Tony,

On Thursday 10 August 2017 03:38 AM, Tony Lindgren wrote:
> * Kishon Vijay Abraham I <kishon@ti.com> [170807 22:22]:
>> The GPIO polarity for MMC1 card detect is set to '0' which means
>> active-high. However the polarity should be active-low. Fix it
>> here.
> 
> Can these wait for v4.14 merge window or do these fix known
> issues?

These can go in the next merge window. I didn't observe any issue without this
in omap_hsmmc driver.

Thanks
Kishon

Re: [PATCH 1/2] ARM: dts: am571x-idk: Fix GPIO polarity for MMC1 card detect

[Tony Lindgren]

* Kishon Vijay Abraham I <kishon@ti.com> [170810 00:46]:
> Tony,
> 
> On Thursday 10 August 2017 03:38 AM, Tony Lindgren wrote:
> > * Kishon Vijay Abraham I <kishon@ti.com> [170807 22:22]:
> >> The GPIO polarity for MMC1 card detect is set to '0' which means
> >> active-high. However the polarity should be active-low. Fix it
> >> here.
> > 
> > Can these wait for v4.14 merge window or do these fix known
> > issues?
> 
> These can go in the next merge window. I didn't observe any issue without this
> in omap_hsmmc driver.

OK applying both into omap-for-v4.14/dt thanks.

Tony