From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753097AbdHJQYw (ORCPT <rfc822;w@1wt.eu>);
        Thu, 10 Aug 2017 12:24:52 -0400
Received: from muru.com ([72.249.23.125]:57616 "EHLO muru.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752381AbdHJQYu (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 10 Aug 2017 12:24:50 -0400
Date: Thu, 10 Aug 2017 09:24:46 -0700
From: Tony Lindgren <tony@atomide.com>
To: Enric Balletbo Serra <eballetbo@gmail.com>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>, linux-pm@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Russell King <linux@armlinux.org.uk>, Lee Jones <lee.jones@linaro.org>,
        Sebastian Reichel <sre@kernel.org>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        Javier Martinez Canillas <javier@dowhile0.org>
Subject: Re: [PATCH 2/4] ARM: dts: tps65217: Add power button interrupt to
 the common tps65217.dtsi file
Message-ID: <20170810162446.GE8569@atomide.com>
References: <20170612212412.22719-1-enric.balletbo@collabora.com>
 <20170612212412.22719-2-enric.balletbo@collabora.com>
 <20170613073519.GA3730@atomide.com>
 <CAFqH_50syu5aHBQtJkh-Dpz8Yc_6w0X853DO46T3ZAAJ10F-Pw@mail.gmail.com>
 <20170614045551.GB3730@atomide.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170614045551.GB3730@atomide.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Tony Lindgren <tony@atomide.com> [170613 22:00]:
> * Enric Balletbo Serra <eballetbo@gmail.com> [170613 02:12]:
> > Hi Tony,
> > 
> > 2017-06-13 9:35 GMT+02:00 Tony Lindgren <tony@atomide.com>:
> > > * Enric Balletbo i Serra <enric.balletbo@collabora.com> [170612 14:28]:
> > >> The interrupt for power button is static data that comes from the
> > >> datasheet, there is no reason to need to define this value on every
> > >> board so seams reasonable put this information into the common tps65217
> > >> file.
> > >
> > > I think there's a problem with these patches where we no longer know
> > > if the interrupts are wired up on a board. For example, if the USB PHY
> > > VBUS interrupt is not connected, the phy driver needs poll the
> > > cable state.
> > >
> > 
> > Hmm, the tps65217 doesn't have a USB PHY like others tps, so not sure
> > how could affect this patch. Did you see this issue in any board that
> > uses tps65217 or any am335x based board which commonly uses this pmic?
> 
> Oh sorry I misread your patch. I thought you're removing
> the interrupts from dts, but you're just moving the dts entries
> to the common dtsi file :) So seems just fine with me.

Applying patches 1 and 2 of this series into omap-for-v4.14/dt
thanks.

Regards,

Tony