From: Keith Busch <keith.busch@intel.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
Jens Axboe <axboe@fb.com>, Martin Peres <martin.peres@intel.com>
Subject: Re: [PATCH v2] nvme: Fix nvme reset command timeout handling
Date: Thu, 10 Aug 2017 12:32:50 -0400 [thread overview]
Message-ID: <20170810163250.GA14634@localhost.localdomain> (raw)
In-Reply-To: <20170810092331.11159-1-jthumshirn@suse.de>
On Thu, Aug 10, 2017 at 11:23:31AM +0200, Johannes Thumshirn wrote:
> From: Keith Busch <keith.busch@intel.com>
>
> We need to return an error if a timeout occurs on any NVMe command during
> initialization. Without this, the nvme reset work will be stuck. A timeout
> will have a negative error code, meaning we need to stop initializing
> the controller. All postitive returns mean the controller is still usable.
>
> bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=196325
>
> Signed-off-by: Keith Busch <keith.busch@intel.com>
> Cc: Martin Peres <martin.peres@intel.com>
> [jth consolidated cleanup path ]
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
This looks great, thanks for fixing that up!
I noticed the HMB setting in pci.c can also potentially timeout. We can
deal with that later.
next prev parent reply other threads:[~2017-08-10 16:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 9:23 [PATCH v2] nvme: Fix nvme reset command timeout handling Johannes Thumshirn
2017-08-10 9:26 ` Christoph Hellwig
2017-08-10 16:32 ` Keith Busch [this message]
2017-08-15 9:05 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810163250.GA14634@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.peres@intel.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox