From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752120AbdHLMgj (ORCPT ); Sat, 12 Aug 2017 08:36:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:48150 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751731AbdHLMge (ORCPT ); Sat, 12 Aug 2017 08:36:34 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACAB922BCC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Sat, 12 Aug 2017 13:08:54 +0100 From: Jonathan Cameron To: "Gustavo A. R. Silva" Cc: Lars-Peter Clausen , Michael Hennerich , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: iio: adc: fix error return code in ad7606_par_probe() Message-ID: <20170812130854.2a87e2f4@archlinux> In-Reply-To: <20170809153856.GA22134@embeddedgus> References: <20170809153856.GA22134@embeddedgus> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Aug 2017 10:38:56 -0500 "Gustavo A. R. Silva" wrote: > platform_get_irq() returns an error code, but the ad7606_par driver > ignores it and always returns -ENODEV. This is not correct and, > prevents -EPROBE_DEFER from being propagated properly. > > Print and propagate the return value of platform_get_irq on failure. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Applied to the togreg branch of iio.git. As we have no reports of anyone actually finding this a problem I'm taking it the slow way and it will wait for the next merge window. Thanks, Jonathan > --- > drivers/staging/iio/adc/ad7606_par.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/adc/ad7606_par.c b/drivers/staging/iio/adc/ad7606_par.c > index cd6c410c..3eb6f8f 100644 > --- a/drivers/staging/iio/adc/ad7606_par.c > +++ b/drivers/staging/iio/adc/ad7606_par.c > @@ -57,8 +57,8 @@ static int ad7606_par_probe(struct platform_device *pdev) > > irq = platform_get_irq(pdev, 0); > if (irq < 0) { > - dev_err(&pdev->dev, "no irq\n"); > - return -ENODEV; > + dev_err(&pdev->dev, "no irq: %d\n", irq); > + return irq; > } > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0);