From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752046AbdHLTWT (ORCPT ); Sat, 12 Aug 2017 15:22:19 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:45327 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750983AbdHLTWS (ORCPT ); Sat, 12 Aug 2017 15:22:18 -0400 Date: Sat, 12 Aug 2017 21:22:15 +0200 From: Pavel Machek To: Bjorn Andersson Cc: Jacek Anaszewski , Richard Purdie , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-arm-msm@vger.kernel.org, Rob Herring , Mark Rutland , devicetree@vger.kernel.org, Fenglin Wu Subject: Re: [PATCH v2 1/3] leds: core: Introduce generic pattern interface Message-ID: <20170812192215.GB23619@amd> References: <20170714224520.467-1-bjorn.andersson@linaro.org> <20170714224520.467-2-bjorn.andersson@linaro.org> <20170706031801.GB12954@xo-6d-61-c0.localdomain> <20170716211456.GV1618@tuxbook> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5/uDoXvLw7AC5HRs" Content-Disposition: inline In-Reply-To: <20170716211456.GV1618@tuxbook> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5/uDoXvLw7AC5HRs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > Hmm, they are only [brightness duration] tuples, and no definition of > > R, G and B LED device is covered here, so how it can be useful for RGB > > LEDs? > >=20 >=20 > The typical Qualcomm PMIC sports 4-8 LPG channels. The output of these > channels can be configured to some extent, but in theory any combination > of the 8 could be hooked up to the three channels of a RGB LED. >=20 > So looking at the LPG hw block, there's no such thing as RGB. Well, there are certainly RGB leds. And we need kernel to know about them, so user can (for example) ask for white color. > Further more, per the 96boards specification we're expected to have > different triggers on the different "colors" of the TRILED. So the specs is stupid. We may end up allowing that, but lets not introduce a bad design just because of that. [You may get that functionality by lying in the dts and claiming it is three LEDs, not one RGB LED.] You want to be able to set a color of RGB LED... which is not as easy as it looks. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --5/uDoXvLw7AC5HRs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlmPVWcACgkQMOfwapXb+vJEDgCgiiqcqBgpIMFFB/ZU8+0/D/RI eRoAoIyeMwcgdAIhPhx1y3Zmg18GpW0r =OykU -----END PGP SIGNATURE----- --5/uDoXvLw7AC5HRs--