From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752197AbdHLXWv (ORCPT ); Sat, 12 Aug 2017 19:22:51 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33152 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752038AbdHLXWu (ORCPT ); Sat, 12 Aug 2017 19:22:50 -0400 Date: Sat, 12 Aug 2017 16:22:48 -0700 From: Greg Kroah-Hartman To: Hans de Goede Cc: Arnd Bergmann , Michael Thayer , "Knut St . Osmundsen" , Alexander Viro , Larry Finger , Linux Kernel Mailing List , Linux FS-devel Mailing List Subject: Re: [RFC 1/2] misc: Add vboxguest driver for Virtual Box Guest integration Message-ID: <20170812232248.GA20719@kroah.com> References: <20170811132324.6216-1-hdegoede@redhat.com> <20170811132324.6216-2-hdegoede@redhat.com> <82e9619b-0e6d-ae10-28c8-87295ae85389@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <82e9619b-0e6d-ae10-28c8-87295ae85389@redhat.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 12, 2017 at 11:56:22PM +0200, Hans de Goede wrote: > > 'u32' is not an approprioate type for a kernel header, use '__u32' > > instead. > > Huh I thought that u32 was preferred, but I guess that it is not allowed > in uapi headers due to potential conflicts and it should be __u32 in uapi > headers ? The __ version should always be used in structures/variables that cross the user/kernel boundry as they are guaranteed to be correct that way. That is a requirement. Use the "normal" non __ versions for in-kernel only variables. hope this helps, greg k-h