From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751544AbdHNFgq (ORCPT ); Mon, 14 Aug 2017 01:36:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:52164 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936AbdHNFgp (ORCPT ); Mon, 14 Aug 2017 01:36:45 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6AD65239EF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=shawnguo@kernel.org Date: Mon, 14 Aug 2017 13:35:12 +0800 From: Shawn Guo To: Stefan Agner , arm@kernel.org Cc: kernel@pengutronix.de, Fabio Estevam , Andrey Smirnov , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: imx: gpcv2: fix regulator deferred probe Message-ID: <20170814053510.GI31819@dragon> References: <20170802195129.20442-1-stefan@agner.ch> <20170805031321.GP31819@dragon> <4546b5193b819ad78a9663baa41be836@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4546b5193b819ad78a9663baa41be836@agner.ch> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 13, 2017 at 10:12:13PM -0700, Stefan Agner wrote: > Hi Shawn, > > On 2017-08-04 20:13, Shawn Guo wrote: > > On Wed, Aug 02, 2017 at 12:51:29PM -0700, Stefan Agner wrote: > >> If a regulator requests a deferred probe, the power domain gets > >> initialized twice. This leads to a list double add (without > >> list debugging the kernel hangs due to the double add later): > >> > >> WARNING: CPU: 0 PID: 19 at lib/list_debug.c:31 __list_add_valid+0xbc/0xc4 > >> list_add double add: new=c1229754, prev=c12383b4, next=c1229754. > >> > >> Initialize the power domain after we get the regulator. Also do > >> not print an error in case the regulator defers probing. > >> > >> Cc: Fabio Estevam > >> Cc: Andrey Smirnov > >> Cc: linux-arm-kernel@lists.infradead.org > >> Cc: linux-kernel@vger.kernel.org > >> Fixes: 03aa12629fc4 ("soc: imx: Add GPCv2 power gating driver") > >> Signed-off-by: Stefan Agner > > > > Applied, thanks. > > As of 4.13-rc5 this did not make it upstream yet, I guess still on its > way? Yes, Stefan. It's on the way to arm-soc [1], but not yet responded. Shawn [1] https://www.spinics.net/lists/arm-kernel/msg598634.html