From: Greg KH <gregkh@linuxfoundation.org>
To: Frederico Cadete <frederico@cadete.eu>
Cc: linux-kernel@vger.kernel.org, linux@Wolf-Entwicklungen.de
Subject: Re: [PATCH] staging: pi433: fix check for FDEVMSB register mask
Date: Mon, 14 Aug 2017 17:57:10 -0700 [thread overview]
Message-ID: <20170815005710.GA23328@kroah.com> (raw)
In-Reply-To: <20170813194350.8434-1-frederico@cadete.eu>
On Sun, Aug 13, 2017 at 09:43:50PM +0200, Frederico Cadete wrote:
> The code was using the logical negation operator "!", effectively never
> triggering the error path. To check the bitmask we should use the
> bitwise negation "~".
>
> Cleans up sparse warning:
> warning: dubious: x & !y
>
> Signed-off-by: Frederico Cadete <frederico@cadete.eu>
> ---
> drivers/staging/pi433/rf69.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Does not apply to my tree :(
prev parent reply other threads:[~2017-08-15 0:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-13 19:43 [PATCH] staging: pi433: fix check for FDEVMSB register mask Frederico Cadete
2017-08-15 0:57 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815005710.GA23328@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=frederico@cadete.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@Wolf-Entwicklungen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox