From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753098AbdHOA5L (ORCPT ); Mon, 14 Aug 2017 20:57:11 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52924 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752823AbdHOA5K (ORCPT ); Mon, 14 Aug 2017 20:57:10 -0400 Date: Mon, 14 Aug 2017 17:57:10 -0700 From: Greg KH To: Frederico Cadete Cc: linux-kernel@vger.kernel.org, linux@Wolf-Entwicklungen.de Subject: Re: [PATCH] staging: pi433: fix check for FDEVMSB register mask Message-ID: <20170815005710.GA23328@kroah.com> References: <20170813194350.8434-1-frederico@cadete.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170813194350.8434-1-frederico@cadete.eu> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 13, 2017 at 09:43:50PM +0200, Frederico Cadete wrote: > The code was using the logical negation operator "!", effectively never > triggering the error path. To check the bitmask we should use the > bitwise negation "~". > > Cleans up sparse warning: > warning: dubious: x & !y > > Signed-off-by: Frederico Cadete > --- > drivers/staging/pi433/rf69.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Does not apply to my tree :(