From: Cornelia Huck <cohuck@redhat.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
sth@linux.vnet.ibm.com, hoeppner@linux.vnet.ibm.com,
jwi@linux.vnet.ibm.com, ubraun@linux.vnet.ibm.com,
maier@linux.vnet.ibm.com, pasic@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [RFT 13/13] s390: virtio: constify ccw_device_id
Date: Tue, 15 Aug 2017 13:11:55 +0200 [thread overview]
Message-ID: <20170815131155.4156a71d.cohuck@redhat.com> (raw)
In-Reply-To: <1502793344-5368-14-git-send-email-arvind.yadav.cs@gmail.com>
On Tue, 15 Aug 2017 16:05:44 +0530
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> ccw_device_id are not supposed to change at runtime. All functions
> working with ccw_device_id provided by <asm/ccwdev.h> work with
> const ccw_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/s390/virtio/virtio_ccw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c
> index b18fe20..b43dbba 100644
> --- a/drivers/s390/virtio/virtio_ccw.c
> +++ b/drivers/s390/virtio/virtio_ccw.c
> @@ -1307,7 +1307,7 @@ static int virtio_ccw_cio_notify(struct ccw_device *cdev, int event)
> return rc;
> }
>
> -static struct ccw_device_id virtio_ids[] = {
> +static const struct ccw_device_id virtio_ids[] = {
> { CCW_DEVICE(0x3832, 0) },
> {},
> };
Acked-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2017-08-15 11:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 10:35 [RFT 00/13] constify s390 ccw_device_id Arvind Yadav
2017-08-15 10:35 ` [RFT 01/13] s390: ccwdev: constify ccw_device_id Arvind Yadav
2017-08-15 10:35 ` [RFT 02/13] s390: dasd_eckd: " Arvind Yadav
2017-08-15 10:35 ` [RFT 03/13] s390: dasd_fba: " Arvind Yadav
2017-08-15 10:35 ` [RFT 04/13] s390: con3215: " Arvind Yadav
2017-08-15 10:35 ` [RFT 05/13] s390: raw3270: " Arvind Yadav
2017-08-15 10:35 ` [RFT 06/13] s390: tape_34xx: " Arvind Yadav
2017-08-15 10:35 ` [RFT 07/13] s390: tape_3590: " Arvind Yadav
2017-08-15 10:35 ` [RFT 08/13] s390: vmur: " Arvind Yadav
2017-08-15 10:35 ` [RFT 09/13] s390: ctcm: " Arvind Yadav
2017-08-15 10:35 ` [RFT 10/13] s390: lcs: " Arvind Yadav
2017-08-15 10:35 ` [RFT 11/13] s390: qeth: " Arvind Yadav
2017-08-15 10:35 ` [RFT 12/13] s390: zfcp: " Arvind Yadav
2017-08-15 10:35 ` [RFT 13/13] s390: virtio: " Arvind Yadav
2017-08-15 11:11 ` Cornelia Huck [this message]
2017-08-15 11:30 ` [RFT 00/13] constify s390 ccw_device_id Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815131155.4156a71d.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hoeppner@linux.vnet.ibm.com \
--cc=jwi@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=maier@linux.vnet.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=sth@linux.vnet.ibm.com \
--cc=ubraun@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox