From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751622AbdHPIKN (ORCPT ); Wed, 16 Aug 2017 04:10:13 -0400 Received: from mga02.intel.com ([134.134.136.20]:23575 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082AbdHPIKK (ORCPT ); Wed, 16 Aug 2017 04:10:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,381,1498546800"; d="scan'208";a="1206218515" Date: Wed, 16 Aug 2017 11:10:01 +0300 From: Mika Westerberg To: Dan Carpenter Cc: Colin King , Andreas Noever , Michael Jamet , Yehezkel Bernat , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH] thunderbolt: fix incorrect value assigned to req->response_type Message-ID: <20170816081001.GP2369@lahna.fi.intel.com> References: <20170815143133.26500-1-colin.king@canonical.com> <20170815143834.GL2369@lahna.fi.intel.com> <20170815152259.idjvtw5tdg24xj2o@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170815152259.idjvtw5tdg24xj2o@mwanda> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 15, 2017 at 06:22:59PM +0300, Dan Carpenter wrote: > On Tue, Aug 15, 2017 at 05:38:34PM +0300, Mika Westerberg wrote: > > On Tue, Aug 15, 2017 at 03:31:33PM +0100, Colin King wrote: > > > From: Colin Ian King > > > > > > req->response_type is being assigned the sizeof TB_CFG_PKG_RESET > > > and should actually be assigned TB_CFG_PKG_RESET. Fix this. > > > > > > Signed-off-by: Colin Ian King > > > > IIRC I already acked this some time ago ;-) > > > > Acked-by: Mika Westerberg > > > > BTW, you should CC Greg as he has been gathering Thunderbolt related > > patches. I added him now. > > Yeah. I sent this patch on Jun 14. "[PATCH] thunderbolt: Fix reset > response_type" I didn't CC Greg, either. Someone should probably > update MAINTAINERS if Greg needs to get these emails. Indeed. Greg, Andreas, Should we add Greg to the MAINTAINERS so that he will be getting all the thunderbolt related patches? Another way, if we want to make this easier for Greg, is to establish a thunderbolt tree in kernel.org and send pull requests to him directly. Please let me know your preference.