* [PATCH] IB/mlx5: make function mlx5_ib_get_vector_affinity
@ 2017-08-16 9:29 Colin King
2017-08-16 10:03 ` Leon Romanovsky
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-08-16 9:29 UTC (permalink / raw)
To: Matan Barak, Leon Romanovsky, Doug Ledford, Sean Hefty,
Hal Rosenstock, linux-rdma
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function mlx5_ib_get_vector_affinity is local to the source
and does not need to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'mlx5_ib_get_vector_affinity' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/infiniband/hw/mlx5/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index cde7d1ce4a3c..a9e684deb6a4 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -3816,8 +3816,8 @@ static void init_delay_drop(struct mlx5_ib_dev *dev)
mlx5_ib_warn(dev, "Failed to init delay drop debugfs\n");
}
-const struct cpumask *mlx5_ib_get_vector_affinity(struct ib_device *ibdev,
- int comp_vector)
+static const struct cpumask *mlx5_ib_get_vector_affinity(
+ struct ib_device *ibdev, int comp_vector)
{
struct mlx5_ib_dev *dev = to_mdev(ibdev);
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] IB/mlx5: make function mlx5_ib_get_vector_affinity
2017-08-16 9:29 [PATCH] IB/mlx5: make function mlx5_ib_get_vector_affinity Colin King
@ 2017-08-16 10:03 ` Leon Romanovsky
0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2017-08-16 10:03 UTC (permalink / raw)
To: Colin King
Cc: Matan Barak, Doug Ledford, Sean Hefty, Hal Rosenstock, linux-rdma,
kernel-janitors, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 619 bytes --]
On Wed, Aug 16, 2017 at 10:29:40AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function mlx5_ib_get_vector_affinity is local to the source
> and does not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'mlx5_ib_get_vector_affinity' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/infiniband/hw/mlx5/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Hi Colin,
It was already posted to the mailing list:
https://patchwork.kernel.org/patch/9901353/
Thanks
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-16 10:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-16 9:29 [PATCH] IB/mlx5: make function mlx5_ib_get_vector_affinity Colin King
2017-08-16 10:03 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox