From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751702AbdHPJwm (ORCPT ); Wed, 16 Aug 2017 05:52:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58786 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751212AbdHPJwk (ORCPT ); Wed, 16 Aug 2017 05:52:40 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4E577C01F564 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sbrivio@redhat.com Date: Wed, 16 Aug 2017 11:52:33 +0200 From: Stefano Brivio To: Juergen Gross Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com, stable@vger.kernel.org Subject: Re: [PATCH] net/i40e: use cpumask_copy() for assigning cpumask Message-ID: <20170816115233.6cc33078@elisabeth> In-Reply-To: <20170812160946.2278-1-jgross@suse.com> References: <20170812160946.2278-1-jgross@suse.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 16 Aug 2017 09:52:40 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Juergen, On Sat, 12 Aug 2017 18:09:46 +0200 Juergen Gross wrote: > Using direct assignment for a cpumask is wrong, cpumask_copy() should > be used instead. Perhaps a Fixes: tag might be helpful here, such as: Fixes: 96db776a3682 ("i40e/i40evf: fix interrupt affinity bug") as I reported in my other (late) patch: http://marc.info/?l=linux-netdev&m=150279303222066&w=2 > Cc: stable@vger.kernel.org and maybe also an indication about which versions this applies to, such as Cc: stable@vger.kernel.org # 4.10+ In general, feel free to copy from my commit message. These comments also apply to: [PATCH] net/i40evf: use cpumask_copy() for assigning cpumask Thanks, -- Stefano