From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752457AbdHPOET (ORCPT <rfc822;w@1wt.eu>);
        Wed, 16 Aug 2017 10:04:19 -0400
Received: from LGEAMRELO12.lge.com ([156.147.23.52]:41415 "EHLO
        lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752371AbdHPOES (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 16 Aug 2017 10:04:18 -0400
X-Original-SENDERIP: 156.147.1.121
X-Original-MAILFROM: byungchul.park@lge.com
X-Original-SENDERIP: 10.177.222.33
X-Original-MAILFROM: byungchul.park@lge.com
Date: Wed, 16 Aug 2017 23:04:14 +0900
From: Byungchul Park <byungchul.park@lge.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org,
        juri.lelli@gmail.com, kernel-team@lge.com
Subject: Re: [PATCH v6 1/2] sched/deadline: Add support for SD_PREFER_SIBLING
 on find_later_rq()
Message-ID: <20170816140414.GW20323@X58A-UD3R>
References: <1502077834-11137-1-git-send-email-byungchul.park@lge.com>
 <1502077834-11137-2-git-send-email-byungchul.park@lge.com>
 <20170815111940.07c7f3de@gandalf.local.home>
 <20170816003810.GO20323@X58A-UD3R>
 <20170815214201.15b6424b@gandalf.local.home>
 <20170816021736.GP20323@X58A-UD3R>
 <20170816093244.6e35f423@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170816093244.6e35f423@gandalf.local.home>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 16, 2017 at 09:32:44AM -0400, Steven Rostedt wrote:
> On Wed, 16 Aug 2017 11:17:36 +0900
> Byungchul Park <byungchul.park@lge.com> wrote:
> 
> 
> > Yes, that's what I intended. IOW:
> > 
> > If (we found a proper sd, not having SD_PREFER_SIBLING?)
> > 	use the sd;
> > else if (we found a proper sd, having SD_PREFER_SIBLING?)
> > 	use the smallest sd among SD_PREFER_SIBLING sds;
> 
> BTW, what do you mean by "smallest sd"?

There might be more than one SD_PREFER_SIBLING domain in its hierachy.
In that case, we have to choose one of them. Imagine the following
example, in case that the source cpu is cpu 0:

[Domain hierachy for cpu 0]

cpu 0 -+ domain 1                 -+
       | SD_PREFER_SIBLING flaged  |
cpu 1 -+                           +- domain 2
                                   |  SD_PREFER_SIBLING flaged
cpu 2 -+---------------------------+
       |
cpu 3 -+

In this case, we have to choose domain 1 than 2, because cpus in domain 1
are closer to the source cpu, cpu 0. That's what I meant.