From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Pratyush Anand" <panand@redhat.com>,
김동현 <austinkernel.kim@gmail.com>,
john.stultz@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: RCU stall when using function_graph
Date: Wed, 16 Aug 2017 10:58:05 -0700 [thread overview]
Message-ID: <20170816175805.GB7017@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170816124140.0b4b10e3@gandalf.local.home>
On Wed, Aug 16, 2017 at 12:41:40PM -0400, Steven Rostedt wrote:
> On Wed, 16 Aug 2017 09:32:28 -0700
> "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
>
> > Let me see if I understand you... About halfway to the stall limit,
> > RCU triggers an irq_work (on each CPU that has not yet passed through
> > a quiescent state, IPIing them in turn?), and if the irq_work has
> > not completed by the end of the stall limit, RCU adds that to its
> > stall-warning message.
>
> Doesn't even have to be half way through. It could be done at the
> limit, and then wait a little more.
Agreed. However, I take other evasive action halfway through, so there
is a nice place to put the code.
> > Or am I missing something here?
>
> No, I think that's what I was suggesting.
I don't see a way of canceling an irq_work.
Ah, but there is an irq_work_queue_on() that fails if still pending.
I should be able to use that instead of cancel. Plus, -I- don't have
to send the IPIs, I can just let irq_work_queue_on() do my dirty work!
This should provide sufficient entertainment for a bit! ;-)
Thanx, Paul
next prev parent reply other threads:[~2017-08-16 17:58 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 22:04 RCU stall when using function_graph Paul E. McKenney
2017-08-01 22:15 ` Daniel Lezcano
2017-08-02 0:12 ` Steven Rostedt
2017-08-02 12:42 ` Daniel Lezcano
2017-08-02 13:07 ` Steven Rostedt
2017-08-03 2:40 ` Paul E. McKenney
2017-08-03 11:41 ` Daniel Lezcano
2017-08-03 12:44 ` Paul E. McKenney
2017-08-03 14:38 ` Daniel Lezcano
[not found] ` <CAOoBcBXo-=VYy2+TYEp=8+WSkOpDBr1x6uY=-r_GnTFKctXndQ@mail.gmail.com>
[not found] ` <CAOoBcBVKpQkAVXji5qQu8r8GErqxpy9Ae9N97NhGpOQPgXudZg@mail.gmail.com>
[not found] ` <CAOoBcBU00VRXmrNNEOjJHgXf9BimxKYOorJC0d3766mNdda=Bg@mail.gmail.com>
2017-08-06 17:02 ` Paul E. McKenney
2017-08-09 9:13 ` Pratyush Anand
2017-08-09 12:58 ` Paul E. McKenney
2017-08-09 13:28 ` Daniel Lezcano
2017-08-09 14:40 ` Paul E. McKenney
2017-08-09 15:51 ` Daniel Lezcano
2017-08-09 17:22 ` Paul E. McKenney
2017-08-10 9:45 ` Daniel Lezcano
2017-08-10 21:39 ` Paul E. McKenney
2017-08-11 9:38 ` Daniel Lezcano
2017-08-15 13:29 ` Steven Rostedt
2017-08-16 8:42 ` Daniel Lezcano
2017-08-16 14:04 ` Steven Rostedt
2017-08-16 16:32 ` Paul E. McKenney
2017-08-16 16:41 ` Steven Rostedt
2017-08-16 17:58 ` Paul E. McKenney [this message]
2017-08-30 22:07 ` Paul E. McKenney
2017-08-02 16:51 ` Paul E. McKenney
2017-08-02 12:49 ` Paul E. McKenney
-- strict thread matches above, loose matches on Subject: below --
2017-08-01 21:07 Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170816175805.GB7017@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=austinkernel.kim@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=panand@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).