From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752551AbdHPVoT (ORCPT ); Wed, 16 Aug 2017 17:44:19 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:36765 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752453AbdHPVoR (ORCPT ); Wed, 16 Aug 2017 17:44:17 -0400 Date: Thu, 17 Aug 2017 00:44:10 +0300 From: Alexey Dobriyan To: Chris Mi Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch net-next 1/3] idr: Use unsigned long instead of int Message-ID: <20170816214410.GA13430@avx2> References: <1502849538-14284-1-git-send-email-chrism@mellanox.com> <1502849538-14284-2-git-send-email-chrism@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502849538-14284-2-git-send-email-chrism@mellanox.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [CC trimmed] On Tue, Aug 15, 2017 at 10:12:16PM -0400, Chris Mi wrote: > IDR uses internally radix tree which uses unsigned long. It doesn't > makes sense to have index as signed value. It doesn't. But it makes sense to use "unsigned int" because it generates smaller code on x86_64.