From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752750AbdHQONO (ORCPT ); Thu, 17 Aug 2017 10:13:14 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:47192 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751949AbdHQONM (ORCPT ); Thu, 17 Aug 2017 10:13:12 -0400 Date: Thu, 17 Aug 2017 07:13:04 -0700 From: "Paul E. McKenney" To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, Ingo Molnar , Will Deacon , Alan Stern , Andrea Parri , Linus Torvalds Subject: Re: [PATCH v5 tip/core/rcu 4/9] completion: Replace spin_unlock_wait() with lock/unlock pair Reply-To: paulmck@linux.vnet.ibm.com References: <20170724221252.GA14238@linux.vnet.ibm.com> <1500934389-14942-4-git-send-email-paulmck@linux.vnet.ibm.com> <20170815161629.GA14379@linux.vnet.ibm.com> <20170817082616.t34xbzbpdxd2lye2@gmail.com> <20170817123038.GK7017@linux.vnet.ibm.com> <20170817124909.5hhinhjguokxecp4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170817124909.5hhinhjguokxecp4@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17081714-0052-0000-0000-00000251481A X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007561; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000222; SDB=6.00903647; UDB=6.00452701; IPR=6.00683859; BA=6.00005538; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016739; XFM=3.00000015; UTC=2017-08-17 14:13:09 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17081714-0053-0000-0000-000051B3F266 Message-Id: <20170817141304.GP7017@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-17_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1708170235 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 17, 2017 at 02:49:09PM +0200, Ingo Molnar wrote: > > * Paul E. McKenney wrote: > > > > this change - or can I pick this up into the scheduler tree? > > > > Timely question! ;-) > > > > My current plan is to send you a pull request like the following later > > today, Pacific Time (but rebased adding Steve Rostedt's Reviewed-by). > > This patch is on one of the branches, currently v4.13-rc2..93d8d7a12090 > > ("arch: Remove spin_unlock_wait() arch-specific definitions") in my > > -rcu tree. > > > > Ah, and v4.13-rc2..7391304c4959 ("membarrier: Expedited private command") > > is mostly outside of RCU as well. > > > > Since I will be rebasing and remerging anyway, if you would prefer that I > > split the spin_unlock_wait() and/or misc branches out, I am happy to do so. > > If I don't hear otherwise, though, I will send all seven branches using > > my usual approach. > > > > So, if you want something different than my usual approach, please just > > let me know! > > No, all branches together sounds good to me! Very good, will do! > If you are rebasing anyway, here are some (very minor) commit title nits I noticed: > > > swait: add idle variants which don't contribute to load average > > rcu: use idle versions of swait to make idle-hack clear > > Capitalization. Will fix! Believe it or not, I looked for these... :-/ > > membarrier: Expedited private command > > Should start with a verb. OK, something like "Provide expedited private command". > > doc: RCU documentation update > > doc: Update RCU documentation > > ? Works for me! > > doc: No longer allowed to use rcu_dereference on non-pointers > > doc: Describe that it is no longer allowed to use rcu_dereference() on non-pointers > > ? Will add a real commit log. > > torture: Add --kconfig argument to kvm.sh > > rcutorture: Don't wait for kernel when all builds fail > > Is there a difference between 'torture: ' and 'rcutorture: ' prefixes? Yes, rcutorture is specific to RCU, while torture would also affect locktorture. Ah, and if I am delaying the cond_resched() patch, I need to retest, which means I will send you the pull request tomorrow or Monday, depending on how the testing goes. Thanx, Paul > Thanks, > > Ingo >