* [PATCH] drm: tegra: add CONFIG_OF dependency
@ 2017-07-21 16:13 Arnd Bergmann
2017-07-25 8:25 ` Jon Hunter
2017-08-17 15:20 ` Thierry Reding
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2017-07-21 16:13 UTC (permalink / raw)
To: Thierry Reding, David Airlie, Jonathan Hunter
Cc: Arnd Bergmann, Stephen Boyd, robdclark, Philipp Zabel, dri-devel,
linux-tegra, linux-kernel
Without CONFIG_OF, we can run into a build error:
drivers/gpu/drm/tegra/dpaux.c:378:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
.dt_node_to_map = pinconf_generic_dt_node_to_map_group,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
pinconf_generic_params
drivers/gpu/drm/tegra/dpaux.c:379:17: error: 'pinconf_generic_dt_free_map' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
This adds an explicit dependency.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/tegra/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kconfig
index 2db29d67193d..dc58ab140151 100644
--- a/drivers/gpu/drm/tegra/Kconfig
+++ b/drivers/gpu/drm/tegra/Kconfig
@@ -3,6 +3,7 @@ config DRM_TEGRA
depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
depends on COMMON_CLK
depends on DRM
+ depends on OF
select DRM_KMS_HELPER
select DRM_MIPI_DSI
select DRM_PANEL
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm: tegra: add CONFIG_OF dependency
2017-07-21 16:13 [PATCH] drm: tegra: add CONFIG_OF dependency Arnd Bergmann
@ 2017-07-25 8:25 ` Jon Hunter
2017-07-25 11:53 ` Arnd Bergmann
2017-08-17 15:20 ` Thierry Reding
1 sibling, 1 reply; 4+ messages in thread
From: Jon Hunter @ 2017-07-25 8:25 UTC (permalink / raw)
To: Arnd Bergmann, Thierry Reding, David Airlie
Cc: Stephen Boyd, robdclark, Philipp Zabel, dri-devel, linux-tegra,
linux-kernel
On 21/07/17 17:13, Arnd Bergmann wrote:
> Without CONFIG_OF, we can run into a build error:
>
> drivers/gpu/drm/tegra/dpaux.c:378:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
> .dt_node_to_map = pinconf_generic_dt_node_to_map_group,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> pinconf_generic_params
> drivers/gpu/drm/tegra/dpaux.c:379:17: error: 'pinconf_generic_dt_free_map' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
>
> This adds an explicit dependency.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/tegra/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kconfig
> index 2db29d67193d..dc58ab140151 100644
> --- a/drivers/gpu/drm/tegra/Kconfig
> +++ b/drivers/gpu/drm/tegra/Kconfig
> @@ -3,6 +3,7 @@ config DRM_TEGRA
> depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
> depends on COMMON_CLK
> depends on DRM
> + depends on OF
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> select DRM_PANEL
Thanks Arnd. I am curious if it can still fail if PINCTRL is not
selected in whatever config you are using?
That said ...
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: tegra: add CONFIG_OF dependency
2017-07-25 8:25 ` Jon Hunter
@ 2017-07-25 11:53 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2017-07-25 11:53 UTC (permalink / raw)
To: Jon Hunter
Cc: Thierry Reding, David Airlie, Stephen Boyd, Rob Clark,
Philipp Zabel, dri-devel, open list:TEGRA ARCHITECTURE SUPPORT,
Linux Kernel Mailing List
On Tue, Jul 25, 2017 at 10:25 AM, Jon Hunter <jonathanh@nvidia.com> wrote:
>
> On 21/07/17 17:13, Arnd Bergmann wrote:
>> Without CONFIG_OF, we can run into a build error:
>>
>> drivers/gpu/drm/tegra/dpaux.c:378:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
>> .dt_node_to_map = pinconf_generic_dt_node_to_map_group,
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> pinconf_generic_params
>> drivers/gpu/drm/tegra/dpaux.c:379:17: error: 'pinconf_generic_dt_free_map' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
>>
>> This adds an explicit dependency.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> drivers/gpu/drm/tegra/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kconfig
>> index 2db29d67193d..dc58ab140151 100644
>> --- a/drivers/gpu/drm/tegra/Kconfig
>> +++ b/drivers/gpu/drm/tegra/Kconfig
>> @@ -3,6 +3,7 @@ config DRM_TEGRA
>> depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
>> depends on COMMON_CLK
>> depends on DRM
>> + depends on OF
>> select DRM_KMS_HELPER
>> select DRM_MIPI_DSI
>> select DRM_PANEL
>
> Thanks Arnd. I am curious if it can still fail if PINCTRL is not
> selected in whatever config you are using?
I have not run into other those problems in many randconfig builds.
Looking at the driver now, I see it has an "#ifdef CONFIG_GENERIC_PINCONF"
to handle that case.
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: tegra: add CONFIG_OF dependency
2017-07-21 16:13 [PATCH] drm: tegra: add CONFIG_OF dependency Arnd Bergmann
2017-07-25 8:25 ` Jon Hunter
@ 2017-08-17 15:20 ` Thierry Reding
1 sibling, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2017-08-17 15:20 UTC (permalink / raw)
To: Arnd Bergmann
Cc: David Airlie, Jonathan Hunter, Stephen Boyd, robdclark,
Philipp Zabel, dri-devel, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 811 bytes --]
On Fri, Jul 21, 2017 at 06:13:23PM +0200, Arnd Bergmann wrote:
> Without CONFIG_OF, we can run into a build error:
>
> drivers/gpu/drm/tegra/dpaux.c:378:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
> .dt_node_to_map = pinconf_generic_dt_node_to_map_group,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> pinconf_generic_params
> drivers/gpu/drm/tegra/dpaux.c:379:17: error: 'pinconf_generic_dt_free_map' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
>
> This adds an explicit dependency.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/tegra/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-17 15:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-21 16:13 [PATCH] drm: tegra: add CONFIG_OF dependency Arnd Bergmann
2017-07-25 8:25 ` Jon Hunter
2017-07-25 11:53 ` Arnd Bergmann
2017-08-17 15:20 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox