From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753396AbdHQRFN (ORCPT <rfc822;w@1wt.eu>);
        Thu, 17 Aug 2017 13:05:13 -0400
Received: from mga01.intel.com ([192.55.52.88]:33582 "EHLO mga01.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752536AbdHQRFK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 17 Aug 2017 13:05:10 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.41,388,1498546800"; 
   d="scan'208";a="301482614"
Date: Thu, 17 Aug 2017 10:04:53 -0700
From: Andi Kleen <ak@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>, jolsa@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] perf, tools: Avoid segfault on alias parse error
Message-ID: <20170817170453.GL28715@tassilo.jf.intel.com>
References: <20170816220201.19182-1-andi@firstfloor.org>
 <20170816220201.19182-3-andi@firstfloor.org>
 <20170817152816.GC10891@kernel.org>
 <20170817164213.GE10891@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170817164213.GE10891@kernel.org>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> So it will _not_ set to null a member that it doesn't have, i.e. the
> minimal fix is to just have the hunks below, making sure that the error
> field is present in both structs. No need to set
> parse_event_terms->error to anything, it will be set to null since other
> fields are set to something.

Right but I want to see the error too. That is why I added a real 
error handler.

-Andi