* [PATCH] staging: olpc_dcon: Fix coding style issue caught bycheckpatch.pl related to function name in debug print
@ 2017-08-05 16:12 张树荣
2017-08-17 18:01 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: 张树荣 @ 2017-08-05 16:12 UTC (permalink / raw)
To: Jens Frederich, Daniel Drake, Jon Nettleton, Greg Kroah-Hartman
Cc: devel, linux-kernel
Replace hard-coded function names in strings with "%s", __func__
in the olpc_dcon.c file. Issue found by checkpatch.pl.
Signed-off-by: Marvin Zhang <MarvinZhang.kernel@gmail.com>
---
drivers/staging/olpc_dcon/olpc_dcon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c
b/drivers/staging/olpc_dcon/olpc_dcon.c
index f7f3a78..429ca58 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon.c
+++ b/drivers/staging/olpc_dcon/olpc_dcon.c
@@ -456,7 +456,7 @@ static ssize_t dcon_freeze_store(struct device *dev,
if (ret)
return ret;
- pr_info("dcon_freeze_store: %lu\n", output);
+ pr_info("%s: %lu\n",__func__, output);
switch (output) {
case 0:
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: olpc_dcon: Fix coding style issue caught bycheckpatch.pl related to function name in debug print
2017-08-05 16:12 [PATCH] staging: olpc_dcon: Fix coding style issue caught bycheckpatch.pl related to function name in debug print 张树荣
@ 2017-08-17 18:01 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2017-08-17 18:01 UTC (permalink / raw)
To: 张树荣
Cc: Jens Frederich, Daniel Drake, Jon Nettleton, devel, linux-kernel
On Sun, Aug 06, 2017 at 12:12:47AM +0800, 张树荣 wrote:
> Replace hard-coded function names in strings with "%s", __func__
> in the olpc_dcon.c file. Issue found by checkpatch.pl.
Your subject line is too long :(
>
> Signed-off-by: Marvin Zhang <MarvinZhang.kernel@gmail.com>
> ---
> drivers/staging/olpc_dcon/olpc_dcon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c
> b/drivers/staging/olpc_dcon/olpc_dcon.c
> index f7f3a78..429ca58 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -456,7 +456,7 @@ static ssize_t dcon_freeze_store(struct device *dev,
> if (ret)
> return ret;
>
> - pr_info("dcon_freeze_store: %lu\n", output);
> + pr_info("%s: %lu\n",__func__, output);
Your patch is corrupted and can not be applied :(
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-17 18:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-05 16:12 [PATCH] staging: olpc_dcon: Fix coding style issue caught bycheckpatch.pl related to function name in debug print 张树荣
2017-08-17 18:01 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox