From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753548AbdHQSBm (ORCPT ); Thu, 17 Aug 2017 14:01:42 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58644 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753391AbdHQSBl (ORCPT ); Thu, 17 Aug 2017 14:01:41 -0400 Date: Thu, 17 Aug 2017 11:01:42 -0700 From: Greg Kroah-Hartman To: =?utf-8?B?5byg5qCR6I2j?= Cc: Jens Frederich , Daniel Drake , Jon Nettleton , devel , linux-kernel Subject: Re: [PATCH] staging: olpc_dcon: Fix coding style issue caught bycheckpatch.pl related to function name in debug print Message-ID: <20170817180142.GE5980@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 06, 2017 at 12:12:47AM +0800, 张树荣 wrote: > Replace hard-coded function names in strings with "%s", __func__ > in the olpc_dcon.c file. Issue found by checkpatch.pl. Your subject line is too long :( > > Signed-off-by: Marvin Zhang > --- > drivers/staging/olpc_dcon/olpc_dcon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c > b/drivers/staging/olpc_dcon/olpc_dcon.c > index f7f3a78..429ca58 100644 > --- a/drivers/staging/olpc_dcon/olpc_dcon.c > +++ b/drivers/staging/olpc_dcon/olpc_dcon.c > @@ -456,7 +456,7 @@ static ssize_t dcon_freeze_store(struct device *dev, > if (ret) > return ret; > > - pr_info("dcon_freeze_store: %lu\n", output); > + pr_info("%s: %lu\n",__func__, output); Your patch is corrupted and can not be applied :( Please fix up and resend. thanks, greg k-h