From: Tejun Heo <tj@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernfs: Clarify lockdep name for kn->count
Date: Thu, 17 Aug 2017 11:46:13 -0700 [thread overview]
Message-ID: <20170817184612.GA491396@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <1502984996-13618-1-git-send-email-longman@redhat.com>
On Thu, Aug 17, 2017 at 11:49:56AM -0400, Waiman Long wrote:
> The reference count in kernfs_node structure is treated like a rwsem by
> using lockdep instrumentation code. The lockdep name, however, is still
> "s_active" which is carried over from the old sysfs code. As s_active
> is no longer the variable name, its use may confuse users on where the
> lock is when it is reported by lockdep. So it is changed to "kn->count"
> which is how this variable is normally referenced in kernfs code.
>
> Signed-off-by: Waiman Long <longman@redhat.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
prev parent reply other threads:[~2017-08-17 18:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 15:49 [PATCH] kernfs: Clarify lockdep name for kn->count Waiman Long
2017-08-17 18:46 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817184612.GA491396@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox