From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753161AbdHQSqS (ORCPT ); Thu, 17 Aug 2017 14:46:18 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:34767 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752236AbdHQSqR (ORCPT ); Thu, 17 Aug 2017 14:46:17 -0400 Date: Thu, 17 Aug 2017 11:46:13 -0700 From: Tejun Heo To: Waiman Long Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] kernfs: Clarify lockdep name for kn->count Message-ID: <20170817184612.GA491396@devbig577.frc2.facebook.com> References: <1502984996-13618-1-git-send-email-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502984996-13618-1-git-send-email-longman@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 17, 2017 at 11:49:56AM -0400, Waiman Long wrote: > The reference count in kernfs_node structure is treated like a rwsem by > using lockdep instrumentation code. The lockdep name, however, is still > "s_active" which is carried over from the old sysfs code. As s_active > is no longer the variable name, its use may confuse users on where the > lock is when it is reported by lockdep. So it is changed to "kn->count" > which is how this variable is normally referenced in kernfs code. > > Signed-off-by: Waiman Long Acked-by: Tejun Heo Thanks. -- tejun