public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: yinbo.zhu@nxp.com
Cc: linux-devel@gforge.freescale.net,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Harninder Rai <harninder.rai@nxp.com>,
	Ashish Kumar <ashish.kumar@nxp.com>,
	Yuantian Tang <andy.tang@nxp.com>,
	"open list:" <devicetree@vger.kernel.org>,
	"moderated list:" <linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: ls1088a: Add USB support
Date: Fri, 18 Aug 2017 21:02:25 +0800	[thread overview]
Message-ID: <20170818130224.GN7608@dragon> (raw)
In-Reply-To: <1503044085-5024-1-git-send-email-yinbo.zhu@nxp.com>

On Fri, Aug 18, 2017 at 04:14:45PM +0800, yinbo.zhu@nxp.com wrote:
> From: "yinbo.zhu" <yinbo.zhu@nxp.com>
> 
> Fix the issue that usb is not detected on ls1088ardb
> 
> Signed-off-by: yinbo.zhu <yinbo.zhu@nxp.com>
> Signed-off-by: Ran Wang <ran.wang_1@nxp.com>

You are sending an updated patch.  Please have the version number in
subject prefix ...

> ---

... and a change history here.  There are a lot of good examples on the
list.  Please have a check.

>  arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts |  8 ++++++++
>  arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi    | 20 ++++++++++++++++++++
>  2 files changed, 28 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> index 213abb7..6c3c3bc 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> @@ -118,6 +118,14 @@
>  	status = "okay";
>  };
>  
> +&usb0 {
> +	status = "okay";
> +};
> +
> +&usb1 {
> +	status = "okay";
> +};
> +
>  &esdhc {
>  	status = "okay";
>  };

I had already put this on previous version - please sort these labelled
nodes alphabetically.  That said, &usb should go after &sata.

Shawn

  reply	other threads:[~2017-08-18 13:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18  8:14 [PATCH] arm64: dts: ls1088a: Add USB support yinbo.zhu
2017-08-18 13:02 ` Shawn Guo [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-08-17  2:52 yinbo.zhu
2017-08-17 14:02 ` Shawn Guo
2017-08-18  7:48   ` Yinbo Zhu
2017-08-18  8:03     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170818130224.GN7608@dragon \
    --to=shawnguo@kernel.org \
    --cc=andy.tang@nxp.com \
    --cc=ashish.kumar@nxp.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=harninder.rai@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-devel@gforge.freescale.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=will.deacon@arm.com \
    --cc=yinbo.zhu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox