* [PATCH] drm/panel: simple: Fix width and height for Olimex LCD-OLinuXino-4.3TS
@ 2017-07-20 10:29 Jonathan Liu
2017-08-04 4:26 ` [linux-sunxi] " Chen-Yu Tsai
2017-08-18 14:05 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Jonathan Liu @ 2017-07-20 10:29 UTC (permalink / raw)
To: Maxime Ripard, Thierry Reding, David Airlie
Cc: dri-devel, linux-kernel, linux-sunxi, Jonathan Liu
The physical size of the panel is 105.5 (W) x 67.2 (H) x 4.05 (D) mm
but the active display area is 95.04 (W) x 53.856 (H) mm.
The width and height should be set to the active display area.
Signed-off-by: Jonathan Liu <net147@gmail.com>
---
drivers/gpu/drm/panel/panel-simple.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 474fa759e06e..39a622a547e7 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1522,8 +1522,8 @@ static const struct panel_desc olimex_lcd_olinuxino_43ts = {
.modes = &olimex_lcd_olinuxino_43ts_mode,
.num_modes = 1,
.size = {
- .width = 105,
- .height = 67,
+ .width = 95,
+ .height = 54,
},
.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
};
--
2.13.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [linux-sunxi] [PATCH] drm/panel: simple: Fix width and height for Olimex LCD-OLinuXino-4.3TS
2017-07-20 10:29 [PATCH] drm/panel: simple: Fix width and height for Olimex LCD-OLinuXino-4.3TS Jonathan Liu
@ 2017-08-04 4:26 ` Chen-Yu Tsai
2017-08-18 14:05 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Chen-Yu Tsai @ 2017-08-04 4:26 UTC (permalink / raw)
To: Thierry Reding, David Airlie, Jonathan Liu
Cc: Maxime Ripard, dri-devel, linux-kernel, linux-sunxi
On Thu, Jul 20, 2017 at 6:29 PM, Jonathan Liu <net147@gmail.com> wrote:
> The physical size of the panel is 105.5 (W) x 67.2 (H) x 4.05 (D) mm
> but the active display area is 95.04 (W) x 53.856 (H) mm.
>
> The width and height should be set to the active display area.
>
> Signed-off-by: Jonathan Liu <net147@gmail.com>
You probably want:
Fixes: cf5c9e6dc70d ("drm/panel: simple: Add timings for the Olimex
LCD-OLinuXino-4.3TS")
Otherwise,
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
against the panel datasheet linked from Olimex's product page.
This should probably go in through drm-misc?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/panel: simple: Fix width and height for Olimex LCD-OLinuXino-4.3TS
2017-07-20 10:29 [PATCH] drm/panel: simple: Fix width and height for Olimex LCD-OLinuXino-4.3TS Jonathan Liu
2017-08-04 4:26 ` [linux-sunxi] " Chen-Yu Tsai
@ 2017-08-18 14:05 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2017-08-18 14:05 UTC (permalink / raw)
To: Jonathan Liu
Cc: Maxime Ripard, David Airlie, dri-devel, linux-kernel, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 477 bytes --]
On Thu, Jul 20, 2017 at 08:29:43PM +1000, Jonathan Liu wrote:
> The physical size of the panel is 105.5 (W) x 67.2 (H) x 4.05 (D) mm
> but the active display area is 95.04 (W) x 53.856 (H) mm.
>
> The width and height should be set to the active display area.
>
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to drm-misc-next, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-18 14:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-20 10:29 [PATCH] drm/panel: simple: Fix width and height for Olimex LCD-OLinuXino-4.3TS Jonathan Liu
2017-08-04 4:26 ` [linux-sunxi] " Chen-Yu Tsai
2017-08-18 14:05 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox