From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753610AbdHRORq (ORCPT ); Fri, 18 Aug 2017 10:17:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:35918 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753605AbdHRORo (ORCPT ); Fri, 18 Aug 2017 10:17:44 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08A8A22C9A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Fri, 18 Aug 2017 11:17:40 -0300 From: Arnaldo Carvalho de Melo To: Taeung Song Cc: linux-kernel@vger.kernel.org, taeung@kosslab.kr, Namhyung Kim , Jiri Olsa Subject: Re: [PATCH v3 4/5] perf annotate browser: Support --show-nr-samples option Message-ID: <20170818141740.GI10891@kernel.org> References: <1503046023-5646-1-git-send-email-treeze.taeung@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1503046023-5646-1-git-send-email-treeze.taeung@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Aug 18, 2017 at 05:47:03PM +0900, Taeung Song escreveu: > Cc: Namhyung Kim > Cc: Jiri Olsa > Signed-off-by: Taeung Song Ok, now that check for !--stdio is lifted and replaced with: - if (symbol_conf.show_nr_samples && !annotate.use_stdio) { - pr_err("--show-nr-samples is only available in --stdio mode at this time\n"); + if (symbol_conf.show_nr_samples && annotate.use_gtk) { + pr_err("--show-nr-samples is not available in --gtk mode at this time\n"); return ret; } - Arnaldo