From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753044AbdHTNVM (ORCPT ); Sun, 20 Aug 2017 09:21:12 -0400 Received: from mail-pg0-f43.google.com ([74.125.83.43]:33032 "EHLO mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752911AbdHTNVK (ORCPT ); Sun, 20 Aug 2017 09:21:10 -0400 Date: Sun, 20 Aug 2017 18:51:06 +0530 From: Viresh Kumar To: Christophe JAILLET Cc: rjw@rjwysocki.net, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] cpufreq: ti: Fix 'of_node_put' being called twice in error handling path Message-ID: <20170820132106.GA21417@ubuntu> References: <20170819202246.18415-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170819202246.18415-1-christophe.jaillet@wanadoo.fr> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19-08-17, 22:22, Christophe JAILLET wrote: > If 'dev_pm_opp_set_supported_hw()' fails, 'opp_data->opp_node' refcount > will be decremented 2 times. > One, just a few lines above, and another one in the error handling path. > > Fix it by simply moving the 'of_node_put' call of the normal path. > > Signed-off-by: Christophe JAILLET > --- > drivers/cpufreq/ti-cpufreq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c > index a7b5658c0460..b29cd3398463 100644 > --- a/drivers/cpufreq/ti-cpufreq.c > +++ b/drivers/cpufreq/ti-cpufreq.c > @@ -245,8 +245,6 @@ static int ti_cpufreq_init(void) > if (ret) > goto fail_put_node; > > - of_node_put(opp_data->opp_node); > - > ret = PTR_ERR_OR_ZERO(dev_pm_opp_set_supported_hw(opp_data->cpu_dev, > version, VERSION_COUNT)); > if (ret) { > @@ -255,6 +253,8 @@ static int ti_cpufreq_init(void) > goto fail_put_node; > } > > + of_node_put(opp_data->opp_node); > + > register_cpufreq_dt: > platform_device_register_simple("cpufreq-dt", -1, NULL, 0); Acked-by: Viresh Kumar -- viresh