public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Janani S <jananis37@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	adrien.descamps@gmail.com, sergio.paracuellos@gmail.com,
	davem@davemloft.net
Subject: Re: [PATCH] staging:wlan-ng Fix Multiple line dereference
Date: Sun, 20 Aug 2017 11:10:53 -0700	[thread overview]
Message-ID: <20170820181053.GA17478@kroah.com> (raw)
In-Reply-To: <1503060399-16486-1-git-send-email-jananis37@gmail.com>

On Fri, Aug 18, 2017 at 06:16:39PM +0530, Janani S wrote:
> This patch fixes multiple line dereference warning reported
> by checkpatch script.
> 
> Signed-off-by: Janani S <jananis37@gmail.com>
> ---
>  drivers/staging/wlan-ng/hfa384x_usb.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> index ee5fa86..2746e13 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -1345,15 +1345,11 @@ static int hfa384x_usbctlx_complete_sync(struct hfa384x *hw,
>  		kfree(ctlx);
>  	} else if (mode == DOWAIT) {
>  		struct usbctlx_cmd_completor completor;
> +		struct usbctlx_completor *cmplt;
>  
> -		result =
> -		    hfa384x_usbctlx_complete_sync(hw, ctlx,
> -						  init_cmd_completor(&completor,
> -								     &ctlx->
> -								     inbuf.
> -								     cmdresp,
> -								     &cmd->
> -								     result));
> +		cmplt = init_cmd_completor(&completor, &ctlx->inbuf.cmdresp,
> +					   &cmd->result);
> +		result = hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt);
>  	}
>  
>  done:

Someone else sent this same patch right before you did, sorry.

greg k-h

  reply	other threads:[~2017-08-20 18:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18 12:46 [PATCH] staging:wlan-ng Fix Multiple line dereference Janani S
2017-08-20 18:10 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-08-02 12:24 [PATCH] staging:wlan-ng Fix multiple " janani-sankarababu
2017-08-17 18:08 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170820181053.GA17478@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=adrien.descamps@gmail.com \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=jananis37@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sergio.paracuellos@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox