* [PATCH] staging:wlan-ng Fix Multiple line dereference
@ 2017-08-18 12:46 Janani S
2017-08-20 18:10 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Janani S @ 2017-08-18 12:46 UTC (permalink / raw)
To: gregkh
Cc: sergio.paracuellos, davem, adrien.descamps, devel, linux-kernel,
Janani S
This patch fixes multiple line dereference warning reported
by checkpatch script.
Signed-off-by: Janani S <jananis37@gmail.com>
---
drivers/staging/wlan-ng/hfa384x_usb.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index ee5fa86..2746e13 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -1345,15 +1345,11 @@ static int hfa384x_usbctlx_complete_sync(struct hfa384x *hw,
kfree(ctlx);
} else if (mode == DOWAIT) {
struct usbctlx_cmd_completor completor;
+ struct usbctlx_completor *cmplt;
- result =
- hfa384x_usbctlx_complete_sync(hw, ctlx,
- init_cmd_completor(&completor,
- &ctlx->
- inbuf.
- cmdresp,
- &cmd->
- result));
+ cmplt = init_cmd_completor(&completor, &ctlx->inbuf.cmdresp,
+ &cmd->result);
+ result = hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt);
}
done:
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] staging:wlan-ng Fix Multiple line dereference
2017-08-18 12:46 [PATCH] staging:wlan-ng Fix Multiple line dereference Janani S
@ 2017-08-20 18:10 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2017-08-20 18:10 UTC (permalink / raw)
To: Janani S; +Cc: devel, linux-kernel, adrien.descamps, sergio.paracuellos, davem
On Fri, Aug 18, 2017 at 06:16:39PM +0530, Janani S wrote:
> This patch fixes multiple line dereference warning reported
> by checkpatch script.
>
> Signed-off-by: Janani S <jananis37@gmail.com>
> ---
> drivers/staging/wlan-ng/hfa384x_usb.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> index ee5fa86..2746e13 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -1345,15 +1345,11 @@ static int hfa384x_usbctlx_complete_sync(struct hfa384x *hw,
> kfree(ctlx);
> } else if (mode == DOWAIT) {
> struct usbctlx_cmd_completor completor;
> + struct usbctlx_completor *cmplt;
>
> - result =
> - hfa384x_usbctlx_complete_sync(hw, ctlx,
> - init_cmd_completor(&completor,
> - &ctlx->
> - inbuf.
> - cmdresp,
> - &cmd->
> - result));
> + cmplt = init_cmd_completor(&completor, &ctlx->inbuf.cmdresp,
> + &cmd->result);
> + result = hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt);
> }
>
> done:
Someone else sent this same patch right before you did, sorry.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] staging:wlan-ng Fix multiple line dereference
@ 2017-08-02 12:24 janani-sankarababu
2017-08-17 18:08 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: janani-sankarababu @ 2017-08-02 12:24 UTC (permalink / raw)
To: gregkh
Cc: sergio.paracuellos, davem, adrien.descamps, devel, linux-kernel,
janani-sankarababu
This patch fixes multiple line dereference Warning
reported by checkpatch script. This is done to
simplify the code and make it more readable.
Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
---
drivers/staging/wlan-ng/hfa384x_usb.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index ee5fa86..2746e13 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -1345,15 +1345,11 @@ static int hfa384x_usbctlx_complete_sync(struct hfa384x *hw,
kfree(ctlx);
} else if (mode == DOWAIT) {
struct usbctlx_cmd_completor completor;
+ struct usbctlx_completor *cmplt;
- result =
- hfa384x_usbctlx_complete_sync(hw, ctlx,
- init_cmd_completor(&completor,
- &ctlx->
- inbuf.
- cmdresp,
- &cmd->
- result));
+ cmplt = init_cmd_completor(&completor, &ctlx->inbuf.cmdresp,
+ &cmd->result);
+ result = hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt);
}
done:
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] staging:wlan-ng Fix multiple line dereference
2017-08-02 12:24 [PATCH] staging:wlan-ng Fix multiple " janani-sankarababu
@ 2017-08-17 18:08 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2017-08-17 18:08 UTC (permalink / raw)
To: janani-sankarababu
Cc: devel, linux-kernel, adrien.descamps, sergio.paracuellos, davem
On Wed, Aug 02, 2017 at 05:54:49PM +0530, janani-sankarababu wrote:
> This patch fixes multiple line dereference Warning
> reported by checkpatch script. This is done to
> simplify the code and make it more readable.
>
> Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
Same "From:" line problem again :(
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-20 18:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-18 12:46 [PATCH] staging:wlan-ng Fix Multiple line dereference Janani S
2017-08-20 18:10 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2017-08-02 12:24 [PATCH] staging:wlan-ng Fix multiple " janani-sankarababu
2017-08-17 18:08 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox