From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752499AbdHUIIa (ORCPT ); Mon, 21 Aug 2017 04:08:30 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:49772 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751182AbdHUII2 (ORCPT ); Mon, 21 Aug 2017 04:08:28 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 804486076B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=bgoswami@codeaurora.org Date: Mon, 21 Aug 2017 01:08:16 -0700 From: Banajit Goswami To: Peng Donglin Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, plai@codeaurora.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH 08/12] ASoC: qcom: Remove useless function call Message-ID: <20170821080816.GA8000@codeaurora.org> References: <1503207837-16310-1-git-send-email-dolinux.peng@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1503207837-16310-1-git-send-email-dolinux.peng@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 20, 2017 at 01:43:57PM +0800, Peng Donglin wrote: > The function platform_set_drvdata(pdev, data) copies the value of > the variable data to pdev->dev.driver_data,but when calling > snd_soc_register_card,the function dev_set_drvdata(card->dev, card) > will override it, so i think that the former copy operation is > useless and can be removed. > > Signed-off-by: Peng Donglin Acked-by: Banajit Goswami > --- > sound/soc/qcom/apq8016_sbc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/soc/qcom/apq8016_sbc.c b/sound/soc/qcom/apq8016_sbc.c > index d084d74..5292591 100644 > --- a/sound/soc/qcom/apq8016_sbc.c > +++ b/sound/soc/qcom/apq8016_sbc.c > @@ -191,7 +191,6 @@ static int apq8016_sbc_platform_probe(struct platform_device *pdev) > if (IS_ERR(data->spkr_iomux)) > return PTR_ERR(data->spkr_iomux); > > - platform_set_drvdata(pdev, data); > snd_soc_card_set_drvdata(card, data); > > return devm_snd_soc_register_card(&pdev->dev, card); > -- > 1.9.1 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel