Re: [PATCH v7 4/4] boot/param: add pointer to next argument to unknown parameter callback

msuchanek
2017-08-24T12:17:44Z

On Thu, 24 Aug 2017 21:04:51 +1000
Michael Ellerman <mpe@ellerman.id.au> wrote:

> Michal Suchanek <msuchanek@suse.de> writes:
>
> > The fadump parameter processing re-does the logic of next_arg quote
> > stripping to determine where the argument ends. Pass pointer to the
> > next argument instead to make this more robust.
> >
> > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > ---
> > arch/powerpc/kernel/fadump.c | 13 +++++--------
> > arch/powerpc/mm/hugetlbpage.c | 4 ++--
> > include/linux/moduleparam.h | 2 +-
> > init/main.c | 12 ++++++------
> > kernel/module.c | 4 ++--
> > kernel/params.c | 19 +++++++++++--------
> > lib/dynamic_debug.c | 2 +-
> > 7 files changed, 28 insertions(+), 28 deletions(-)
>
> Can you split out a patch that adds the next argument and updates the
> callers. And then a patch for the fadump to use the new arg.
>
> cheers

Yes, that makes sense.

Thanks

Michal