From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754371AbdHUVlp (ORCPT ); Mon, 21 Aug 2017 17:41:45 -0400 Received: from mx4.wp.pl ([212.77.101.12]:11558 "EHLO mx4.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754135AbdHUVln (ORCPT ); Mon, 21 Aug 2017 17:41:43 -0400 Date: Mon, 21 Aug 2017 14:41:36 -0700 From: Jakub Kicinski To: Christophe JAILLET Cc: kvalo@codeaurora.org, matthias.bgg@gmail.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mt7601u: check memory allocation failure Message-ID: <20170821144136.477bf655@cakuba.netronome.com> In-Reply-To: <20170821143430.635e4b92@cakuba.netronome.com> References: <20170821205956.20859-1-christophe.jaillet@wanadoo.fr> <20170821143430.635e4b92@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: 501038c001997b921e90ea44f8c3f4c9 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 000000A [EWPE] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Aug 2017 14:34:30 -0700, Jakub Kicinski wrote: > On Mon, 21 Aug 2017 22:59:56 +0200, Christophe JAILLET wrote: > > Check memory allocation failure and return -ENOMEM in such a case, as > > already done a few lines below > > > > Signed-off-by: Christophe JAILLET > > Acked-by: Jakub Kicinski Wait, I take that back. This code is a bit weird. We would return an error, then mt7601u_dma_init() will call mt7601u_free_tx_queue() which doesn't check for tx_q == NULL condition. Looks like mt7601u_free_tx() has to check for dev->tx_q == NULL and return early if that's the case. Or mt7601u_alloc_tx() should really clean things up on it's own on failure. Ugh.