From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754012AbdHUTTl (ORCPT <rfc822;w@1wt.eu>);
        Mon, 21 Aug 2017 15:19:41 -0400
Received: from mail.kernel.org ([198.145.29.99]:50302 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753600AbdHUTTk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 21 Aug 2017 15:19:40 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C35921456
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org
Date: Mon, 21 Aug 2017 16:19:37 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
        linux-kernel@vger.kernel.org, taeung@kosslab.kr,
        Namhyung Kim <namhyung@kernel.org>,
        Milian Wolff <milian.wolff@kdab.com>, Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH v3 5/5] perf annotate browser: Circulate percent, total
 period and samples view
Message-ID: <20170821191937.GK10891@kernel.org>
References: <1503046028-5691-1-git-send-email-treeze.taeung@gmail.com>
 <20170818142314.GJ10891@kernel.org>
 <1136b710-2012-fc5b-cee6-7b4b82e742ba@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1136b710-2012-fc5b-cee6-7b4b82e742ba@gmail.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Mon, Aug 21, 2017 at 02:47:09PM +0900, Taeung Song escreveu:
> 
> 
> On 08/18/2017 11:23 PM, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Aug 18, 2017 at 05:47:08PM +0900, Taeung Song escreveu:
> > > With a existing 't' hotkey, support the three view based on percent,
> > > total period and number of samples on the annotate TUI browser,
> > > circulating them like below:
> > > 
> > >    Percent -> Period -> Samples -> Percent ...
> > > 
> > > Suggested-by: Namhyung Kim <namhyung@kernel.org>
> > > Cc: Milian Wolff <milian.wolff@kdab.com>
> > > Cc: Jiri Olsa <jolsa@redhat.com>
> > > Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> > > ---
> > 
> > Ok, here I removed this part, that is not documented in the patch nor in
> > the 'h' help screen, if you think it should be considered, please
> > resubmit it with a proper explanation:
> 
> I'm really sorry. The case 'e' code is a residue..
> I missed removing the code.
> Thank you for indicating my mistakes.
> 
> Do I resend this patchkit based on your changes ?
> Or, will you modify it by yourself ?

I fixed it myself, sending to Ingo now.

Thanks!

- Arnaldo