From: Josef Bacik <josef@toxicpanda.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: josef@toxicpanda.com, linux-kernel@vger.kernel.org,
kernel-team@fb.com, Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH] sched/fair: move definitions to fix !CONFIG_SMP
Date: Mon, 21 Aug 2017 16:44:39 -0400 [thread overview]
Message-ID: <20170821204438.GI23807@destiny> (raw)
In-Reply-To: <20170821200653.GC32112@worktop.programming.kicks-ass.net>
On Mon, Aug 21, 2017 at 10:06:53PM +0200, Peter Zijlstra wrote:
> On Mon, Aug 21, 2017 at 04:03:05PM -0400, josef@toxicpanda.com wrote:
> > From: Josef Bacik <jbacik@fb.com>
> >
> > The series of patches adding runnable_avg and subsequent supporting
> > patches broke on !CONFIG_SMP. Fix this by moving the definitions under
> > the appropriate checks, and moving the !CONFIG_SMP definitions higher
> > up.
>
> Is this on top or can I fold this in somewhere? I was meaning to rework
> the series to avoid this superfluous build borkage.
There's actually a lot of individual breakages. I can go through and make
individual patches that can be folded in to where they were introduced, or I can
do them all at once. There's breakage around !CONFIG_FAIR_GROUP_SCHED as well,
basically everything you added needs to be moved around some. I'll do whatever
is most convenient for you. Thanks,
Josef
next prev parent reply other threads:[~2017-08-21 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 20:03 [PATCH] sched/fair: move definitions to fix !CONFIG_SMP josef
2017-08-21 20:06 ` Peter Zijlstra
2017-08-21 20:44 ` Josef Bacik [this message]
2017-08-21 20:20 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170821204438.GI23807@destiny \
--to=josef@toxicpanda.com \
--cc=jbacik@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox