From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932714AbdHVMUf (ORCPT <rfc822;w@1wt.eu>);
        Tue, 22 Aug 2017 08:20:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39868 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932427AbdHVMUe (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 22 Aug 2017 08:20:34 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8D04A61471
Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=oleg@redhat.com
Date: Tue, 22 Aug 2017 14:20:30 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
        Kees Cook <keescook@chromium.org>,
        Troy Kensinger <tkensinger@google.com>,
        "security@kernel.org" <security@kernel.org>,
        Paul McKenney <paulmck@linux.vnet.ibm.com>,
        Josh Triplett <josh@joshtriplett.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] pids: make task_tgid_nr_ns() safe
Message-ID: <20170822122030.GA2193@redhat.com>
References: <CAMKL9z2A8VSmLc9gz4Vtd1N5nGwR5d9Mxi1Nc8VjTQKsURoMkA@mail.gmail.com>
 <CA+55aFyfaBZmDVSpx3F7cQZcck8u_vg53wL1ykRE-ccgrtg14w@mail.gmail.com>
 <CAGXu5jKLDAnKoRg_v8Nc7s6AtQ6_QfaMtJorjFkbaX64MDHy2g@mail.gmail.com>
 <CA+55aFy+0cQUcPjWmnD8qFL2gHVYHYTxJmHVy6L=Bz03KaP2Rw@mail.gmail.com>
 <20170820142953.GA3767@redhat.com>
 <CA+55aFzA+0jzTdknmf0OUB7WSPgAa56nqckqdz=iDmbR2P9eRw@mail.gmail.com>
 <20170821153502.GA652@redhat.com>
 <CA+55aFx4LrqTyhn32oSRUCgOaKeAxA4VrL8n7Fke8AQJYkhXSQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+55aFx4LrqTyhn32oSRUCgOaKeAxA4VrL8n7Fke8AQJYkhXSQ@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 22 Aug 2017 12:20:33 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/21, Linus Torvalds wrote:
>
> On Mon, Aug 21, 2017 at 8:35 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > We really need to change __unhash_process() to nullify group_leader,
> > parent, and real_parent, but this needs some cleanups. Until then we
> > can turn task_tgid_nr_ns() into another user of __task_pid_nr_ns() and
> > fix the problem.
>
> Applied.
>
> Should it perhaps have had a "Cc: stable" on it? I didn't do so, but
> it might be worth pointing Greg at this explicitly (dd1c1f2f2028
> "pids: make task_tgid_nr_ns() safe").

Yes, agreed, I forgot to add this tag.

Oleg.