From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933068AbdHVOky (ORCPT ); Tue, 22 Aug 2017 10:40:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:58254 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932785AbdHVOkx (ORCPT ); Tue, 22 Aug 2017 10:40:53 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E45B2156A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Tue, 22 Aug 2017 11:40:50 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Andi Kleen , jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH v2 01/19] perf, tools: Save max_x, max_y in xyarray Message-ID: <20170822144050.GL10891@kernel.org> References: <20170811232634.30465-1-andi@firstfloor.org> <20170822082028.GC23985@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170822082028.GC23985@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Aug 22, 2017 at 10:20:28AM +0200, Jiri Olsa escreveu: > On Fri, Aug 11, 2017 at 04:26:16PM -0700, Andi Kleen wrote: > > From: Andi Kleen > > +static inline int xy_max_y(struct xyarray *xy) > > +{ > > + return xy->max_x; > > +} > > + > > +static inline int xy_max_x(struct xyarray *xy) > > +{ > > + return xy->max_y; > > +} > > I think you should follow the standard naming > and use xyarray__max_x and xyarray__max_y Yeah, will take just a bit longer to process, I'll fix that up... - Arnaldo