Re: [PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings

Jiri Olsa
2017-08-23T14:14:08Z

On Wed, Aug 23, 2017 at 07:00:32AM -0700, Andi Kleen wrote:
> > Andi,
> > how is this 'Remote' different from the remote levels in mem_lvl?
> >
> > "Remote RAM (1 hop)",
> > "Remote RAM (2 hops)",
> > "Remote Cache (1 hop)",
> > "Remote Cache (2 hops)",
>
> It applies to any other level. This is needed to express
> "Remote unknown level", as is reported by Skylake.

so if I find HITM with this flag set I should count it
as remote HITM then? something like attached.. untested

thanks,
jirka

---
diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
index 06f5a3a4295c..65e22b9e59f9 100644
--- a/tools/perf/util/mem-events.c
+++ b/tools/perf/util/mem-events.c
@@ -279,6 +279,7 @@ int c2c_decode_stats(struct c2c_stats *stats, struct mem_info *mi)
u64 lvl = data_src->mem_lvl;
u64 snoop = data_src->mem_snoop;
u64 lock = data_src->mem_lock;
+ bool mr = data_src->mem_remote;
int err = 0;

#define HITM_INC(__f) \
@@ -324,7 +325,7 @@ do { \
}

if ((lvl & P(LVL, REM_RAM1)) ||
- (lvl & P(LVL, REM_RAM2))) {
+ (lvl & P(LVL, REM_RAM2)) || mr) {
stats->rmt_dram++;
if (snoop & P(SNOOP, HIT))
stats->ld_shared++;
@@ -334,7 +335,7 @@ do { \
}

if ((lvl & P(LVL, REM_CCE1)) ||
- (lvl & P(LVL, REM_CCE2))) {
+ (lvl & P(LVL, REM_CCE2)) || mr) {
if (snoop & P(SNOOP, HIT))
stats->rmt_hit++;
else if (snoop & P(SNOOP, HITM))